chore: build-system submodule=>subrepo #1378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's move build-system to a subrepo. The tradeoffs for submodules are worse.
Subrepo has some edge cases but for me they're now well understood. The major thing is it optimizes for the normal case by being just normal files plus a metadata file. Even if subrepo messes up sync'ing to the upstream repo, aztec keeps its base truth moving and we can sync later.
Pros over submodules:
Cons:
Do we still want the other repo: I say default yes as long as it's basically free. We can punt folding it in if it causes pain