fix: Fixed a failing test and added a small fuzzer #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
approved these changes
Aug 2, 2023
Rumata888
commented
Aug 2, 2023
| @@ -184,6 +185,102 @@ concept InstructionWeightsEnabled = requires { | |||
| typename T::InstructionWeights; | |||
| T::InstructionWeights::_LIMIT; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
This is a function I've added for the future. I hope to create a variadic template for buffer mutations of elements so that anyone can build a fuzzer in 5 minutes with cool mutations
Thanks for reviewing. I'll ask @ledwards2225 to review the crypto part |
Rumata888
commented
Aug 2, 2023
| @@ -0,0 +1,275 @@ | |||
| /** | |||
| * @file goblin_translator_circuit_builder.cpp | |||
There was a problem hiding this comment.
I simply moved this code from .test.cpp and commented out all info and variables used just for info (messed with fuzzing)
Rumata888
commented
Aug 2, 2023
| ASSERT(uint256_t(limbs[NUM_BINARY_LIMBS - 1]) < (uint256_t(1) << NUM_LAST_LIMB_BITS)); | ||
| } else { | ||
|
|
||
| ASSERT(uint256_t(limbs[NUM_BINARY_LIMBS - 1]) < (SHIFT_1)); |
Rumata888
commented
Aug 2, 2023
| using Fr = ::curve::BN254::ScalarField; | ||
| using Fq = ::curve::BN254::BaseField; | ||
|
|
||
| extern "C" int LLVMFuzzerTestOneInput(const unsigned char* data, size_t size) |
There was a problem hiding this comment.
Created a mini-fuzzer which explored possible values and quickly found the assert issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goblin translator tests were failing due to an incorrect assert (with certain probability). Added a small fuzzer that helped find the bug.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.