Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: checking if "from" is registered #1393

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: checking if "from" is registered #1393

merged 2 commits into from
Aug 3, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Aug 3, 2023

Fixes #1230

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan marked this pull request as draft August 3, 2023 08:40
@benesjan benesjan force-pushed the janb/checking-origin branch from 2b35709 to b7f1147 Compare August 3, 2023 08:50
@benesjan benesjan marked this pull request as ready for review August 3, 2023 09:26
@benesjan benesjan enabled auto-merge (squash) August 3, 2023 09:26
@PhilWindle
Copy link
Collaborator

Just verifying, this checks that the 'from' address is registered in the wallet, not the origin?

@benesjan
Copy link
Contributor Author

benesjan commented Aug 3, 2023 •
edited
Loading

Just verifying, this checks that the 'from' address is registered in the wallet, not the origin?

@PhilWindle yes, sorry for the bad wording.

@benesjan benesjan changed the title feat: checking if origin is registered feat: checking if "from" is registered Aug 3, 2023
spalladino
spalladino approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a small unit test, just for the sake of it?

@benesjan benesjan merged commit 8b3a064 into master Aug 3, 2023
@benesjan benesjan deleted the janb/checking-origin branch August 3, 2023 12:56
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@joss-aztec
Merge pull request #1393 from AztecProtocol/defi-bridge-project
2c19389 
Isolate for Monday 12th Sep release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalladino spalladino spalladino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make send method check whether origin address is registered
3 participants
@benesjan @PhilWindle @spalladino