Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aztec-js): remove sender from execution request and add batching #1415

Merged
merged 8 commits into from
Aug 4, 2023
Merged

feat(aztec-js): remove sender from execution request and add batching #1415

merged 8 commits into from
Aug 4, 2023

Conversation

spalladino
Copy link
Collaborator

@spalladino spalladino commented Aug 3, 2023 •
edited
Loading

A few clean ups in aztec-js:

  • Remove from in ExecutionRequest and rename it to FunctionCall to avoid confusion with TxExecutionRequest and CallStackItem.isExecutionRequest.
  • Remove TxContext argument from AccountImp.createAuthenticatedTx and rename it to createTxExecutionRequest.
  • Remove unused nonce in method send options.
  • Remove unused function to get a contract instance in deploy method given we now have feat(aztec-js): Return contract instance when awaiting deploy tx #1360.
  • Extracts a base class for contract_function_interaction and deploy_method so we can remove the DeployWallet.
  • Adds a new BatchCall method for nicer batch calls. Fixes Add API to aztec.js for batching actions #1343.

@spalladino spalladino force-pushed the palla/js-api-tweaks branch from 0ec2a51 to c8565e1 Compare August 3, 2023 19:27
@spalladino spalladino changed the title chore(aztec-js): remove sender from execution request chore(aztec-js): remove sender from execution request and batch method Aug 3, 2023
@spalladino spalladino changed the title chore(aztec-js): remove sender from execution request and batch method feat(aztec-js): remove sender from execution request and add batching Aug 3, 2023
@spalladino spalladino marked this pull request as ready for review August 3, 2023 20:45
@spalladino spalladino enabled auto-merge (squash) August 3, 2023 20:45
benesjan
benesjan approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. LGTM

@spalladino spalladino merged commit 05b6e86 into master Aug 4, 2023
@spalladino spalladino deleted the palla/js-api-tweaks branch August 4, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API to aztec.js for batching actions
2 participants
@spalladino @benesjan