Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): pin noir version to aztec tag #1461

Merged
merged 1 commit into from
Aug 8, 2023
Merged

feat(ci): pin noir version to aztec tag #1461

merged 1 commit into from
Aug 8, 2023

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Aug 8, 2023

TLDR:
This pins the noir release to the aztec tag on the noir repo.
This is out of sync with nightly and can be manually bumped by us.

Overview
Myself and kev had a little sync and have a nice minimal solution that should unblock us for the meantime.
We have created a dedicated tag aztec within noir that points to a fixed commit.
This is good as we do not need to bring noir compilation into our CI, we can leverage noir's existing build pipelines to rebuild commits for us.
If we need to retag the release, we can run

git tag -f -a aztec <commit>
git push -f origin refs/tags/aztec

Then trigger a build in the build-nargo pipeline to create the release for us.
Our ci will then automatically target that commit.
Longer term solutions:

  1. The noir compiler package discussed above.
  2. Increasing retention for nightly builds, tagging them with a unique tag, changing that tag within aztec's git repo.
  3. Creating CI that will auto generate new artifacts on aztec tag releases.

@Maddiaa0 Maddiaa0 enabled auto-merge (squash) August 8, 2023 14:24
@Maddiaa0 Maddiaa0 changed the title feat: pin noir commit to aztec tag feat(ci): pin noir version to aztec tag Aug 8, 2023
@Maddiaa0 Maddiaa0 merged commit afe601a into master Aug 8, 2023
@Maddiaa0 Maddiaa0 deleted the md/pin-noir branch August 8, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants