Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: removed getPreimagesAt #1517

Merged
merged 1 commit into from
Aug 11, 2023
Merged

refactor: removed getPreimagesAt #1517

merged 1 commit into from
Aug 11, 2023

Conversation

benesjan
Copy link
Contributor

Fixes #1502

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@benesjan benesjan enabled auto-merge (squash) August 11, 2023 08:26
@benesjan benesjan merged commit 7e14e7b into master Aug 11, 2023
@benesjan benesjan deleted the janb/removed-getpreimageat branch August 11, 2023 08:46
@LHerskind
Copy link
Contributor

What is the reasoning behind removing this?

We have #1285 where we want to provide it with the cheat codes, which currently just use the rpc 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the getPreimagesAt api from AztecRPC
3 participants
@benesjan @LHerskind @PhilWindle