hack(ordering): public state action ordering #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanks12
commented
Aug 21, 2023
This was referenced Aug 21, 2023
Test to replicate: public kernel outputs wrong final state for insertion into public data tree
#1617
Closed
jeanmon
requested changes
Aug 21, 2023
yarn-project/sequencer-client/src/sequencer/public_processor.ts
Outdated
Show resolved
Hide resolved
jeanmon
approved these changes
Aug 21, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Attempt to fix production deployment (#1683) * Add stefan to mainframe. Deployment publishes bb.js and blockchain to npm. * Fix block scanning (#1692) * Attempt to fix deploy. * Fix dai-permit issues. Providers did not offset `v` properly (#1698) * fix: perform offset to `sig.v if 0 or 1 for `signTypedData` * fix: remove git-submodules * Force to -O2 with binaryen installed to prevent aes bug. * Updated fork block number (#1685) * Updated fork block number * Updated fork block and element test tranche * Removed no longer used env variable * Updated Faucet index page amounts * [zk-money] Jcf/aave (#1642) * Configure aave defi cards * copy-paste error * Increase test timeout Co-authored-by: PhilWindle <philip.windle@gmail.com> * fix aave token addresses (#1701) * Fuzzer-found bugs that are not related to bigfield (#1605) * Added a regression test to detect original parallelized asm bugs * FIxed parallelized SQR asm bugs * Added comment that Emerson wanted * Fix for create_range_constraint in the constant case * Various safe_uint bug fixes having to do with not handling constant cases * Fixed the comparison issue for the point at infinity * Added regression tests and fixed 3 more missing flags in optimized SQR * Fixed tabulation in asm_macros.hpp * Fixed Montgomery Issue that Adrian Found * Fixed issue with negative zero found by Guido * FIxed same self_neg bug found by Guido * Renamed 1 test * Fixed one more SQR bug * Added extra regression tests * Slightly moved one test * Added TODO comments into field_impl for potential optimisations * Addressed Zac's comments Co-authored-by: zac-williamson <blorktronics@gmail.com> * Fixing errors in addition and subtraction of field elements with moduli > 254 bits (#1702) * Added test * Added bugfixes * Added comments * Use 400k gas bridge for aave (#1705) * Add versioning to falafel status endpoint. Refresh zk-money on version mismatch. (#1674) * all get/post reqs from sdk to falafel now include header * falafel expects all endpoint requests to be given a 'version' header. SDK now gives all reqs a version. If falafel sees a req with version that does not match falafel version, it responds with error 402. ServerRollupProvider now emits versionMismatch whenever one occurs. zk-money promotes this event and forces refresh of browser. * cleanup new FALAFEL_VERSION constant in falafel - using configurator everywhere instead of using constant directly * fix prettier errors * prettier server.ts * sdk version to 0 * version is now a str like 2.1.0 in falafel and sdk. moved getRollupProviderStatus into SDK so that it doesn't need to accept sdk_version as arg * prettier sdk index.ts * zk-money alerts on version mismatch. Falafel allows requests without version header, but if version header is present it enforces a match. * server rollup provider and block source shouldn't NEED a to interact with falafel. * prettier rollup provider ts * block source / provider fix version default undefined changed to '' Co-authored-by: joss-aztec <94053499+joss-aztec@users.noreply.github.com> Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: zac-williamson <blorktronics@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1617
Resolves #1622
Resolves #1623
Patches the
PublicDataReadsandPublicDataUpdateRequestscoming from the public kernel to reorder them properly until public state is properly reordered (#757).