Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: intial private kernel #549

Merged
merged 47 commits into from
May 25, 2023
Merged

feat: intial private kernel #549

merged 47 commits into from
May 25, 2023

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented May 11, 2023 •
edited by jeanmon
Loading

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Resolves #503

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

dbanks12 added 2 commits May 11, 2023 23:41
@dbanks12
prelim / very-broken commit where Jean and I started implementing the…
55e6016 
… initial private kernel and moving logic between it and the inner kernel
@dbanks12
merge in master
c3d954b
@dbanks12 dbanks12 mentioned this pull request May 12, 2023
Closed
jeanmon and others added 27 commits May 12, 2023 12:21
@jeanmon
wip - fix some compilation issues, remove unused imports, remove
ac8f8f0 
update_end_values leftover
@jeanmon
wip - some minor changes and comments after pairing with David
ea7816d
@jeanmon
Merge branch 'master' into db-jm/initial-private-kernel
6f01a62
@jeanmon
wip: additional compilation fixes
080d814
@jeanmon
Merge branch 'master' into db-jm/initial-private-kernel
0fe88a6
@jeanmon
Refactor helper functions in private kernel tests
952095e
@jeanmon
wip - Fix linking issue and comment out some tests
1a4cfb6
@jeanmon
wip - repair native and circuit tests
75d5b17
@jeanmon
wip - include using double quotes and remove unused code
f294a0a
@jeanmon
wip - fixing circuit_create_proof_cbinds test and adapting
6c73b8a 
private_kernel_sim function to the inner/init split
@jeanmon
wip - fix clang tidy issue
64678ea
@jeanmon
Merge branch 'master' into db-jm/initial-private-kernel
3575556
@jeanmon
wip - post master merger fixes and remove test on new nullifiers
9f8ebe2
@jeanmon
wip - fix clang tidy issue
a5b378f
@jeanmon
Merge branch 'master' into db-jm/intial-private-kernel
f4e5e1e
@jeanmon
wip - fix clang tidy issue
9a6c83c
@jeanmon
wip - fix typescript tests and data structure split
7c07ed3
@jeanmon
wip - format typescript
0b5dc0e
@jeanmon
wip - replace CONSTRUCTOR_ARGS by FUNCTION_ARGS
7df1400
@jeanmon
Merge branch 'master' into db-jm/intial-private-kernel
bd1b7ad
@jeanmon
wip - add nullifier and l1-l2-message tree roots in initial private
f0ae663 
kernel circuit
@jeanmon
Merge branch 'master' into db-jm/intial-private-kernel
db30ebd
@jeanmon
wip - post merge fix
9bbef1c
@jeanmon
Migrate common.hpp functions into non-templated ones
e71af78
@Maddiaa0 @jeanmon
refactor(sol): use Hash.sha256ToField library where required (#637)
886363b 
* refactor(sol): use Hash.sha256ToField library where required

* fmt :)

* feat: expose bytes32 hash directly

* fmt: https://i.pinimg.com/originals/81/23/a1/8123a132c007eab782d6ca9bed517eb3.jpg

---------

Co-authored-by: Maddiaa0 <addaboy@gmail.com>
@LHerskind @rahul-kothari @jeanmon
fix: Add checks for arg-type (#638)
3cd5293 
* fix: Add checks for arg-type

* fix: support arg of 'number' type

* fix: correct wrapped fr in acir sim

* no need to force encode in some e2e tests!

---------

Co-authored-by: Maddiaa0 <addaboy@gmail.com>
Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
@Maddiaa0 @jeanmon
fix: naming consistency in messaging (messageHash -> message) (#641)
3ecd3bc 
* fix: contentHash -> content

* fix: update content in nr

* fix: update incorrect message hash naming

---------

Co-authored-by: Maddiaa0 <addaboy@gmail.com>
@jeanmon jeanmon self-assigned this May 23, 2023
@jeanmon jeanmon added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label May 23, 2023
@jeanmon jeanmon requested a review from suyash67 May 23, 2023 17:25
@jeanmon jeanmon marked this pull request as ready for review May 23, 2023 17:39
dbanks12
dbanks12 commented May 23, 2023
View reviewed changes
Copy link
Collaborator Author

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can't approve since I'm an author otherwise I would. Left a few comments but most of them are minor and could be put off to another PR.

circuits/cpp/src/aztec3/circuits/abis/c_bind.test.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/.test.cpp Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.hpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_inner.cpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_inner.hpp Outdated Show resolved Hide resolved
circuits/cpp/src/aztec3/constants.hpp Outdated Show resolved Hide resolved
suyash67
suyash67 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@suyash67 suyash67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after all the comments/suggestions are resolved.

@suyash67 suyash67 merged commit 032f2a0 into master May 25, 2023
@suyash67 suyash67 deleted the db-jm/intial-private-kernel branch May 25, 2023 13:15
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@kevaundray
fix: Update versioning in nix files when a release is made (#549)
1521e87
This was referenced Jul 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanmon jeanmon jeanmon left review comments

@suyash67 suyash67 suyash67 approved these changes

Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create native_private_kernel_initial function
6 participants
@dbanks12 @suyash67 @jeanmon @Maddiaa0 @LHerskind @spalladino