Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(avm-simulator): make storage work across enqueued calls #6181

Merged
merged 5 commits into from
May 7, 2024
Merged

feat(avm-simulator): make storage work across enqueued calls #6181

merged 5 commits into from
May 7, 2024

Conversation

fcarreiro
Copy link
Contributor

No description provided.

@fcarreiro Graphite App
Copy link
Contributor Author

fcarreiro commented May 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

@fcarreiro fcarreiro requested a review from dbanks12 May 3, 2024 14:05
@fcarreiro fcarreiro mentioned this pull request May 3, 2024
Merged
@fcarreiro fcarreiro force-pushed the fc/avm-storage-across-enqueued-calls branch 2 times, most recently from d966123 to f29b328 Compare May 3, 2024 16:13
dbanks12
dbanks12 approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait to merge until my stack is merged.

dbanks12
dbanks12 reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if it would be cleaner to (maybe later / in another PR) do something similar to nullifiers and maybe initialize an enqueued calls's PublicStorage with the previous enqueued call's as a parent?

@fcarreiro fcarreiro force-pushed the fc/avm-storage-across-enqueued-calls branch from f29b328 to b9acabf Compare May 7, 2024 10:25
@fcarreiro fcarreiro force-pushed the fc/avm-storage-across-enqueued-calls branch from 62043e0 to 46c74f8 Compare May 7, 2024 14:54
@fcarreiro Graphite App
Copy link
Contributor Author

fcarreiro commented May 7, 2024 •
edited
Loading

Merge activity

@fcarreiro fcarreiro merged commit 8e218a2 into master May 7, 2024
62 checks passed
@fcarreiro fcarreiro deleted the fc/avm-storage-across-enqueued-calls branch May 7, 2024 16:05
This was referenced May 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanks12 dbanks12 dbanks12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcarreiro @dbanks12