-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate public to avm simulator #6448
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @fcarreiro and the rest of your teammates on Graphite |
5d6513a
to
6f39822
Compare
6f39822
to
2a1f2a6
Compare
52f6fa3
to
2a8da61
Compare
28a0fd5
to
3c6d42c
Compare
773fba2
to
9b116e4
Compare
2a8da61
to
6ac7f77
Compare
bf86310
to
895dfa6
Compare
Docs PreviewHey there! 👋 You can check your preview at https://664d208c93cb4b43ff4d6d9d--aztec-docs-dev.netlify.app |
cadddc9
to
e250a18
Compare
Benchmark resultsNo base data found for comparison. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | Transaction processing duration by data writes.
|
d659d23
to
8f4187c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/docs/migration_notes.md
Outdated
## TBD | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TBD intended to mean "release number TBD"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! It gets changed before the actual release, but maybe I could just do 0.42
docs/docs/migration_notes.md
Outdated
@@ -6,6 +6,26 @@ keywords: [sandbox, cli, aztec, notes, migration, updating, upgrading] | |||
|
|||
Aztec is in full-speed development. Literally every version breaks compatibility with the previous ones. This page attempts to target errors and difficulties you might encounter when upgrading, and how to resolve them. | |||
|
|||
## TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move it into 0.41?
docs/docs/migration_notes.md
Outdated
|
||
**What does this mean for me?** | ||
|
||
It should be mostly transparent, with a few caveats: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great! Thank you! Everything before it feels like it can be in docs and doesn't need to be in these notes. We tend to keep these notes as succinct as possible
8f4187c
to
99cf496
Compare
99cf496
to
1e0ce40
Compare
1e0ce40
to
734951c
Compare
734951c
to
2f6093b
Compare
This PR migrates the public (execution) environment to use the AVM simulator. The idea of this PR is to be as minimal as possible, as to enable easy rollbacks if needed. If things go well, there is a lot of cleanup to do afterwards, which we are tracking in this issue.
Major Changes
PublicContext
gets replaced with what was theAvmContext
.Other changes
bench_tx_size_fees
since the cost is now different (bytecode and L2 gas changes).