refactor: purge secret and open keywords

[sklppy88]

Resolves #5538

[sklppy88]

• refactor: purge secret and open keywords #6501 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[benesjan]

Hello, why have you opened this one when #6450 was not sent for a review yet?

I am about to modify key store now and there will be conflicts now because you don't seem to try to minimize time to master. This slows everything down.

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://664c7c2613c2321306b27069--aztec-docs-dev.netlify.app

[sklppy88]

Hello, why have you opened this one when #6450 was not sent for a review yet?

I am about to modify key store now and there will be conflicts now because you don't seem to try to minimize time to master. This slows everything down.

I have a question to raise in scrum regarding the other PR, and didn't want to bother you or Lasse with it outside of the scrum. I'm trying to learn Graphite here and continue with tasks. The feedback on the other PR has been addressed, and the question has to do with the interface for nsk rotation. Fair point though I'll message in the chat w/ my question.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_witness_generation_time_in_ms (base-parity): 2,151 (+823%)
• protocol_circuit_witness_generation_time_in_ms (base-rollup): 5,611 (+19%)
• protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 721 (-33%)
• protocol_circuit_proving_time_in_ms (merge-rollup): 1,635 (-25%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	772	772	772
l1_rollup_calldata_gas	6,856	6,856	6,844
l1_rollup_execution_gas	587,396	587,396	587,384
l2_block_processing_time_in_ms	1,360 (+1%)	5,100 (+1%)	10,161 (+1%)
l2_block_building_time_in_ms	33,698 (+1%)	132,309 (+1%)	263,368 (+1%)
l2_block_rollup_simulation_time_in_ms	33,510 (+1%)	131,669 (+1%)	262,110 (+1%)
l2_block_public_tx_process_time_in_ms	15,715 (+2%)	66,934 (+2%)	134,676 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	15,315 (+1%)	28,554 (+1%)
node_database_size_in_bytes	21,422,160	38,371,408
pxe_database_size_in_bytes	29,868	59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	protocol_circuit_simulation_time_in_ms	protocol_circuit_witness_generation_time_in_ms	protocol_circuit_proving_time_in_ms	protocol_circuit_input_size_in_bytes	protocol_circuit_output_size_in_bytes	protocol_circuit_proof_size_in_bytes	protocol_circuit_num_public_inputs	protocol_circuit_size_in_gates
private-kernel-init	155 (+1%)	3,649	21,168 (-3%)	19,987	61,999	86,720	2,643	1,048,576
private-kernel-inner	545 (+1%)	4,638 (-3%)	40,826 (+1%)	89,054	61,999	86,720	2,643	2,097,152
private-kernel-reset-small	555 (+1%)	2,857 (+11%)	23,802 (+3%)	117,897	61,999	86,720	2,643	1,048,576
private-kernel-tail	535 (+1%)	4,012 (-1%)	38,176 (+2%)	86,849	79,454	10,688	267	2,097,152
base-parity	7.67 (+1%)	⚠️ 2,151 (+823%)	4,125 (-2%)	128	64.0	2,208	2.00	131,072
root-parity	48.9	132 (-2%)	39,851 (+2%)	27,064	64.0	2,720	18.0	2,097,152
base-rollup	856	⚠️ 5,611 (+19%)	43,781 (+2%)	111,158	957	3,136	31.0	2,097,152
root-rollup	66.6 (+1%)	175 (+2%)	8,457 (+2%)	11,518	821	3,456	41.0	524,288
public-kernel-app-logic	191 (+1%)	346 (+4%)	⚠️ 721 (-33%)	96,979	85,095	116,448	3,572	4,096
public-kernel-tail	855	727 (-15%)	1,089 (-12%)	388,207	7,755	10,176	251	512
public-kernel-setup	166 (+1%)	376 (-4%)	959 (-4%)	138,310	85,095	116,448	3,572	4,096
public-kernel-teardown	161 (-5%)	393 (-6%)	971 (-1%)	143,321	85,095	116,448	3,572	4,096
merge-rollup	6.51 (+1%)	88.6 (-11%)	⚠️ 1,635 (-25%)	2,760	957	3,136	31.0	65,536
private-kernel-tail-to-public	N/A	9,241 (-2%)	74,401 (+3%)	N/A	N/A	116,960	3,588	4,194,304

Stats on running time collected for app circuits

Function	app_circuit_proof_size_in_bytes	app_circuit_proving_time_in_ms	app_circuit_size_in_gates	app_circuit_num_public_inputs
SchnorrAccount:entrypoint	16,128	49,615 (+3%)	2,097,152	437
Test:emit_nullifier	16,128	2,836 (-2%)	65,536	437
FPC:fee_entrypoint_public	16,128	16,648	524,288	437
FPC:fee_entrypoint_private	16,128	9,334 (+6%)	524,288	437
Token:unshield	16,128	52,029 (+4%)	2,097,152	437
SchnorrAccount:spend_private_authwit	16,128	2,750 (+1%)	131,072	437
Token:transfer	16,128	35,367 (+1%)	2,097,152	437

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	11.4 (+1%)	18.4 (+1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.664 (+1%)	0.566	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	52.4	80.9	261	506	991 (+1%)	1,966 (+1%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.536	0.499	0.474	0.473	0.469	0.469	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	62.8	120 (+1%)	379	743	1,478 (+1%)	2,947 (+1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	106	208	692	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.546	0.539 (+1%)	0.515	0.511	0.512 (+1%)	0.513 (+1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	67.9
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	108
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.595

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	84,743	673,221

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes	2 new note hashes
tx_pxe_processing_time_ms	28,876 (+1%)	3,134 (+1%)	98,259

Metric	0 public data writes	1 public data writes	2 public data writes	4 public data writes	8 public data writes
tx_sequencer_processing_time_ms	1,334 (+2%)	2,161	1,792 (-9%)	2,869 (+4%)	1,765

[sklppy88]

Although secret domain is okay, I changed it here to have consistency with the rest.

[benesjan]

Is it used anywhere?

[sklppy88]

Hmmm, I checked again and I don't think so. Will nuke and see. Thanks !

[benesjan]

LGTM