Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop building/publishing acvm_backend.wasm #6584

Merged
merged 1 commit into from
May 29, 2024

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented May 21, 2024

Noir no longer makes use of this wasm binary so we don't need to keep building/publishing it.

Resolves #1832

@TomAFrench TomAFrench requested a review from ludamad May 21, 2024 21:58
@AztecBot
Copy link
Collaborator

Benchmark results

No base data found for comparison.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256 5,646 1,545 709 773 768

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,856 6,868 6,856
l1_rollup_execution_gas 587,396 587,408 587,396
l2_block_processing_time_in_ms 1,367 5,109 10,086
l2_block_building_time_in_ms 32,647 127,910 256,163
l2_block_rollup_simulation_time_in_ms 32,463 127,265 254,879
l2_block_public_tx_process_time_in_ms 20,441 84,467 168,390

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,232 28,349
node_database_size_in_bytes 21,405,776 38,146,128
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit protocol_circuit_simulation_time_in_ms protocol_circuit_witness_generation_time_in_ms protocol_circuit_proving_time_in_ms protocol_circuit_input_size_in_bytes protocol_circuit_output_size_in_bytes protocol_circuit_proof_size_in_bytes protocol_circuit_num_public_inputs protocol_circuit_size_in_gates
private-kernel-init 158 3,647 22,950 19,985 61,999 86,720 2,643 1,048,576
private-kernel-inner 603 5,077 40,426 89,053 61,999 86,720 2,643 2,097,152
private-kernel-reset-small 572 2,363 23,165 117,961 61,999 86,720 2,643 1,048,576
private-kernel-tail 529 3,869 37,765 86,849 79,454 10,688 267 2,097,152
base-parity 6.53 221 3,399 128 64.0 2,208 2.00 131,072
root-parity 49.6 127 38,329 27,064 64.0 2,720 18.0 2,097,152
base-rollup 803 3,147 43,430 111,158 957 3,136 31.0 2,097,152
root-rollup 94.0 52.0 8,243 11,518 821 3,456 41.0 524,288
public-kernel-app-logic 243 140 928 96,978 85,095 116,448 3,572 4,096
public-kernel-tail 866 675 1,174 388,207 7,755 10,176 251 512
public-kernel-setup 228 191 1,069 138,309 85,095 116,448 3,572 4,096
public-kernel-teardown 225 198 995 143,320 85,095 116,448 3,572 4,096
merge-rollup 6.47 147 1,537 2,760 957 3,136 31.0 65,536
private-kernel-tail-to-public N/A 9,509 72,571 N/A N/A 116,960 3,588 4,194,304

Stats on running time collected for app circuits

Function app_circuit_proof_size_in_bytes app_circuit_proving_time_in_ms app_circuit_size_in_gates app_circuit_num_public_inputs
SchnorrAccount:entrypoint 16,128 47,077 2,097,152 437
Test:emit_nullifier 16,128 1,755 65,536 437
FPC:fee_entrypoint_public 16,128 9,190 524,288 437
FPC:fee_entrypoint_private 16,128 8,881 524,288 437
Token:unshield 16,128 49,922 2,097,152 437
SchnorrAccount:spend_private_authwit 16,128 2,701 131,072 437
Token:transfer 16,128 34,970 2,097,152 437

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.3 18.4 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.658 0.566 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 52.7 81.1 264 503 994 1,962 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.539 0.500 0.479 0.470 0.471 0.468 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 62.8 120 380 739 1,480 2,934 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.545 0.537 0.516 0.509 0.513 0.510 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.7
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.593

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 84,741 673,219

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 29,601 4,253 100,282
Metric 0 public data writes 1 public data writes 2 public data writes 4 public data writes 8 public data writes
tx_sequencer_processing_time_ms 1,432 2,724 1,995 3,352 1,981

@TomAFrench TomAFrench requested review from vezenovm and guipublic May 28, 2024 17:20
@TomAFrench TomAFrench merged commit 7a3a491 into master May 29, 2024
74 checks passed
@TomAFrench TomAFrench deleted the tf/remove-acvm-backend branch May 29, 2024 10:22
TomAFrench added a commit that referenced this pull request May 29, 2024
* master:
  feat: prepare circuit output for validation (#6678)
  chore: stop building/publishing `acvm_backend.wasm` (#6584)
  chore: add bench programs (#6566)
  chore: make public data update requests, note hashes, and unencrypted logs readonly in TS (#6658)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: update honk recursion constraint (#6545)
  feat: Add code-workspace and update build dirs (#6723)
  feat: Sync from noir (#6717)
  feat: folding acir programs (#6685)
  feat: sumcheck part of ECCVM recursive verifier instantiated as an UltraCircuit (#6413)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove acvm_backend.wasm from barretenberg
3 participants