Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avm): base and dynamic gas in TS and CPP (part 2) #8016

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

fcarreiro
Copy link
Contributor

No description provided.

Copy link
Contributor Author

fcarreiro commented Aug 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

@fcarreiro fcarreiro changed the title feat(avm): base and dynamic gas in TS and CPP feat(avm): base and dynamic gas in TS and CPP (part 2) Aug 15, 2024
@AztecBot
Copy link
Collaborator

AztecBot commented Aug 15, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (Token:mint_public): 43.9 (-39%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 68.0 (+36%)
  • avm_simulation_time_ms (Token:transfer_public): 19.7 (-45%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,750 1,556 708 751 (-1%) 765
proof_construction_time_sha256_30_ms 11,803 3,193 (+1%) 1,422 (+1%) 1,450 (+1%) 1,469
proof_construction_time_sha256_100_ms 45,316 (+1%) 12,010 (+1%) 5,502 (+2%) 5,429 5,381 (+1%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 58.0 (-3%) 88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,533 421 202 224 267 (-3%)
proof_construction_time_poseidon_hash_100_ms 5,633 1,515 676 733 (-1%) 750

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,324 7,844 14,852
l1_rollup_calldata_gas 49,744 92,448 177,596
l1_rollup_execution_gas 1,383,193 2,130,865 3,958,052
l2_block_processing_time_in_ms 249 (-15%) 440 (-3%) 817 (+3%)
l2_block_building_time_in_ms 9,368 (-1%) 18,224 36,520
l2_block_rollup_simulation_time_in_ms 9,367 (-1%) 18,223 36,520
l2_block_public_tx_process_time_in_ms 7,891 (-1%) 16,674 34,920

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 2,935 (-1%) 3,788 (-2%)
node_database_size_in_bytes 12,685,392 16,752,720
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 103 (+8%) 393 21,846 44,858 N/A
private-kernel-inner 169 (-3%) 709 (+1%) 72,545 45,005 N/A
private-kernel-reset-tiny 512 (+2%) 1,204 69,614 44,844 N/A
private-kernel-tail 273 (+1%) 196 (-2%) 50,760 52,256 N/A
base-parity 5.56 (-3%) N/A 160 96.0 N/A
root-parity 33.1 (-1%) N/A 69,084 96.0 N/A
base-rollup 2,869 N/A 187,817 664 N/A
root-rollup 39.1 (+1%) N/A 54,525 716 N/A
public-kernel-setup 101 N/A 103,760 71,222 N/A
public-kernel-app-logic 107 (+1%) N/A 103,599 71,222 N/A
public-kernel-tail 575 (+1%) N/A 409,190 16,414 N/A
private-kernel-reset-small 492 (-3%) N/A 66,533 45,629 N/A
private-kernel-tail-to-public 1,473 (+11%) 714 (-1%) 507,554 1,697 N/A
public-kernel-teardown 94.3 N/A 104,005 71,222 N/A
merge-rollup 19.0 (-2%) N/A 35,742 664 N/A
undefined N/A N/A N/A N/A 67,379 (-4%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 347
ContractInstanceDeployer:deploy 1,408 11,731 18.2 (+1%)
MultiCallEntrypoint:entrypoint 1,920 11,731 427 (+1%)
FeeJuice:deploy 1,376 11,731 387 (-1%)
SchnorrAccount:constructor 1,312 11,731 104
SchnorrAccount:entrypoint 2,304 11,731 434
Token:privately_mint_private_note 1,280 11,731 136 (-3%)
FPC:fee_entrypoint_public 1,344 11,731 25.9 (-2%)
Token:transfer 1,312 11,731 283
Benchmarking:create_note 1,344 11,731 101 (-2%)
SchnorrAccount:verify_private_authwit 1,280 11,731 27.7
Token:unshield 1,376 11,731 569 (+2%)
FPC:fee_entrypoint_private 1,376 11,731 758 (+1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 53.9 (+1%) 8,139
FeeJuice:set_portal 10.0 (-1%) 2,362
Token:constructor 82.1 (-3%) 31,107
FPC:constructor 54.0 22,380
FeeJuice:mint_public 38.3 (+1%) 6,150
Token:mint_public ⚠️ 43.9 (-39%) 11,720
Token:assert_minter_and_mint ⚠️ 68.0 (+36%) 8,028
AuthRegistry:set_authorized 37.4 (-19%) 4,537
FPC:prepare_fee 247 (+5%) 8,812
Token:transfer_public ⚠️ 19.7 (-45%) 47,374
FPC:pay_refund 54.9 (-4%) 12,114
Benchmarking:increment_balance 976 7,450
Token:_increase_public_balance 39.9 (+1%) 8,960
FPC:pay_refund_with_shielded_rebate 67.1 (+2%) 12,663

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.163 (-1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.19 (-1%) 3.85 (-2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.113 (-1%) 0.108 (-2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.5 17.9 31.0 (-5%) 59.5 (-1%) 113 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.110 (-1%) 0.103 (-1%) 0.101 (-4%) 0.102 (-1%) 0.101
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.2 (-1%) 26.3 (+1%) 44.6 (+1%) 83.4 (-1%) 161 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.107 (-2%) 0.105 (+1%) 0.107 (+1%) 0.103 (-1%) 0.102
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.4 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.105 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

Copy link
Contributor Author

fcarreiro commented Aug 15, 2024

Merge activity

  • Aug 15, 11:49 AM EDT: @fcarreiro started a stack merge that includes this pull request via Graphite.
  • Aug 15, 11:52 AM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 15, 1:00 PM EDT: @fcarreiro merged this pull request with Graphite.

@fcarreiro fcarreiro changed the base branch from fc/avm-bytes-binary to graphite-base/8016 August 15, 2024 15:49
@fcarreiro fcarreiro changed the base branch from graphite-base/8016 to master August 15, 2024 15:50
@fcarreiro fcarreiro merged commit 5801732 into master Aug 15, 2024
97 checks passed
@fcarreiro fcarreiro deleted the fc/avm-gas-part-2 branch August 15, 2024 17:00
rahul-kothari pushed a commit that referenced this pull request Aug 15, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](#7926))
([f769f84](f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](#8023))
([cee9d9a](cee9d9a))
* Forking world state in prover-node
([#7995](#7995))
([ebffe96](ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
* Private reset kernel
([#7984](#7984))
([0d82c79](0d82c79))
* Sync alphanet back to master
([#7970](#7970))
([523724d](523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](#8016))
([5801732](5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](#8010))
([3ad6dd9](3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-package-v0.49.0...aztec-package-v0.49.1)
(2024-08-15)


### Miscellaneous

* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg.js: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg.js-v0.49.0...barretenberg.js-v0.49.1)
(2024-08-15)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>aztec-packages: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@aztec-packages-v0.49.0...aztec-packages-v0.49.1)
(2024-08-15)


### Features

* Add pending reorg chain resistance in contracts
([#7926](AztecProtocol/aztec-packages#7926))
([f769f84](AztecProtocol/aztec-packages@f769f84))
* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Bug Fixes

* Docker.dockerignore file can be huge.
([#8023](AztecProtocol/aztec-packages#8023))
([cee9d9a](AztecProtocol/aztec-packages@cee9d9a))
* Forking world state in prover-node
([#7995](AztecProtocol/aztec-packages#7995))
([ebffe96](AztecProtocol/aztec-packages@ebffe96))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
* Private reset kernel
([#7984](AztecProtocol/aztec-packages#7984))
([0d82c79](AztecProtocol/aztec-packages@0d82c79))
* Sync alphanet back to master
([#7970](AztecProtocol/aztec-packages#7970))
([523724d](AztecProtocol/aztec-packages@523724d))
</details>

<details><summary>barretenberg: 0.49.1</summary>

##
[0.49.1](AztecProtocol/aztec-packages@barretenberg-v0.49.0...barretenberg-v0.49.1)
(2024-08-15)


### Features

* **avm:** Base and dynamic gas in TS and CPP (part 2)
([#8016](AztecProtocol/aztec-packages#8016))
([5801732](AztecProtocol/aztec-packages@5801732))


### Miscellaneous

* **avm:** Separate binary and bytes finalization
([#8010](AztecProtocol/aztec-packages#8010))
([3ad6dd9](AztecProtocol/aztec-packages@3ad6dd9))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants