fix: correct SIZE_IN_BYTES of CompleteAddress #8282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehmisar
force-pushed
the
om/fix-complete-address-size
branch
from
8dacebc to
d0afa9d
Compare
|
@TomAFrench can this get tested (and then merged)? |
|
@ludamad Does CI allow running from a fork or do we need to recreate this within the repo? |
|
Thanks for this PR @olehmisar, I'm going to close it in favour of #10574 while maintaining you as the contributor. |
TomAFrench
added a commit
that referenced
this pull request
Dec 10, 2024
This PR replaces #8282 as CI won't run for PRs from forks. Co-authored-by: oleh <olehmisar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
SIZE_IN_BYTESforCompleteAddressand add a test to test it