feat!: change AVM PC to byte indexed #9386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/pc-byte-indexed
branch
from
7af4694 to
f2fab02
Compare
dbanks12
force-pushed
the
db/pc-byte-indexed
branch
from
f2fab02 to
4f59b42
Compare
dbanks12
commented
Oct 24, 2024
Comment on lines
98
to
+110
| deserialize: (buf: BufferCursor | Buffer): Instruction => { | ||
| const res = deserialize(buf, wireFormat); | ||
| const args = res.slice(1); // Remove opcode. | ||
| return new this(...args); | ||
| const instance = new this(...args); | ||
| // Need to make sure that deserialized instances can getSize | ||
| return Object.defineProperties(instance, { | ||
| getSize: { | ||
| value: (): number => { | ||
| return getInstructionSize(wireFormat); | ||
| }, | ||
| enumerable: false, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This is ugly.... Is there some way I can get around needing to do this Object.defineProperties() INSIDE an Object.assign(). I'm having trouble thinking of better ways to handle this.
fcarreiro
reviewed
Oct 30, 2024
| @@ -100,6 +100,25 @@ export enum OperandType { | |||
| type OperandNativeType = number | bigint; | |||
| type OperandWriter = (value: any) => void; | |||
|
|
|||
| // Number of bytes that each operand takes up in an instruction | |||
| export const OPERAND_SIZE_BYTES = new Map<OperandType, number>([ | |||
There was a problem hiding this comment.
Only realized now but these are the numbers in OPERAND_SPEC ;)
|
Resolved by #9582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.