Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using bb ECDSA #954

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Using bb ECDSA #954

merged 1 commit into from
Jul 13, 2023

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 4, 2023

Description

Fixes #913

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan force-pushed the janb/using-bb-ecdsa branch from 570518d to 2d1aef1 Compare July 13, 2023 13:46
@benesjan benesjan requested a review from PhilWindle July 13, 2023 14:19
@benesjan benesjan enabled auto-merge (squash) July 13, 2023 14:20
PhilWindle
PhilWindle approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@PhilWindle PhilWindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@benesjan benesjan merged commit 0efa8f1 into master Jul 13, 2023
@benesjan benesjan deleted the janb/using-bb-ecdsa branch July 13, 2023 14:59
spalladino added a commit that referenced this pull request Jul 14, 2023
@spalladino
Revert "chore: using bb ecdsa (#954)"
643963d 
This reverts commit 0efa8f1.
This was referenced Jul 14, 2023
Merged
Closed
spalladino added a commit that referenced this pull request Jul 18, 2023
@spalladino
Revert "chore: using bb ecdsa (#954)"
122deb6 
This reverts commit 0efa8f1.
spalladino added a commit that referenced this pull request Jul 19, 2023
@spalladino
feat(accounts): Store signing public keys in immutable private notes …
3201321 
…in account contracts (#1080)

* Log nargo version when compiling

* Fix get_note and emit encrypted log on initialisation

* Use ecdsa private key for signing instead of encryption key (d'oh!)

* Add noir debug call for arrays with text

* Revert "chore: using bb ecdsa (#954)"

This reverts commit 0efa8f1.

* Properly inject invalid signing key for failing test

* Reenable signature verification in ecdsa contract

* Split SchnorrAccount into single and multi key flavours

* Apply suggestions by @benesjan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ECDSA signer with bb signature once fixed
2 participants
@benesjan @PhilWindle