Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avm): Simulator enforces integral tag for DIV and field tag for FDIV #9944

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

jeanmon
Copy link
Contributor

@jeanmon jeanmon commented Nov 13, 2024

No description provided.

@jeanmon jeanmon marked this pull request as ready for review November 13, 2024 16:59
Copy link
Contributor

@fcarreiro fcarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He, you found a broken test:

Arithmetic Instructions › Div › Should divide correctly › FIELD

@jeanmon jeanmon force-pushed the jm/div-simulator-tag-checks branch from c0a332a to 3389d57 Compare November 13, 2024 18:45
@jeanmon
Copy link
Contributor Author

jeanmon commented Nov 13, 2024

He, you found a broken test:

Arithmetic Instructions › Div › Should divide correctly › FIELD

Thx @fcarreiro. I have fixed it.

@jeanmon jeanmon enabled auto-merge (squash) November 13, 2024 19:10
@jeanmon jeanmon merged commit cebcc3d into master Nov 13, 2024
66 checks passed
@jeanmon jeanmon deleted the jm/div-simulator-tag-checks branch November 13, 2024 19:18
TomAFrench added a commit that referenced this pull request Nov 14, 2024
* master: (245 commits)
  chore: pull signed bitshifts from sync PR (#9939)
  chore: pull frontend changes from sync PR (#9935)
  feat: separate bytecode logs from unencrypted logs (#9891)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  fix: token naming issue (#9950)
  feat: multiplier oracle (#9902)
  refactor: token refunds cleanup (#9943)
  chore: Use stack based recursion instead of function recursion (#9947)
  feat: parallelize DIE pass (#9933)
  feat(avm): Simulator enforces integral tag for DIV and field tag for FDIV (#9944)
  chore(avm): bugfixing witness generation for add, sub, mul for FF (#9938)
  feat: Google Cloud Kubernetes cluster + AWS Firewall Rules (#9915)
  chore: nuking ancient redundant test (#9941)
  fix: include 'master' version for aztec-up scripts (#9940)
  chore: fixing test contract fixture (#9909)
  refactor: token naming cleanup (#9904)
  chore: pull SSA parser from sync PR (#9928)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants