Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment the asserts in Ultra Recursive Verifiers #1032

Closed
maramihali opened this issue Jun 20, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8316
Closed

Uncomment the asserts in Ultra Recursive Verifiers #1032

maramihali opened this issue Jun 20, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8316
Assignees
@lucasxia01

Comments

@maramihali
Copy link
Contributor

We have asserts that check the circuit size and number of public inputs in the verification key is the same as what is received as part of the proofs. These have been commented out in the ultra recursive verifier because some of the flows trigger assertion failures currently because of dummy values being set. We should address this

cc @lucasxia01
@lucasxia01 lucasxia01 mentioned this issue Sep 2, 2024
Merged
@lucasxia01 lucasxia01 self-assigned this Sep 2, 2024
AztecBot pushed a commit that referenced this issue Sep 3, 2024
@lucasxia01 @AztecBot
chore: uncomment asserts in oink rec verifier (#8316)
52422d4 
Closes #1032.

These assert statements were commented out at some point, but they
should not need to be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: uncomment asserts in oink rec verifier AztecProtocol/aztec-packages
2 participants
@maramihali @lucasxia01