-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account required should be checked when skipping signature verification in join_splits #66
Comments
Great catch |
ludamad
pushed a commit
that referenced
this issue
Jan 18, 2023
11 tasks
ludamad
pushed a commit
that referenced
this issue
Jan 18, 2023
LeilaWang
pushed a commit
that referenced
this issue
Jan 20, 2023
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
Closed by #70 |
dbanks12
pushed a commit
that referenced
this issue
Jan 24, 2023
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
dbanks12
pushed a commit
that referenced
this issue
Jan 24, 2023
* fix(join_split): Check account flag. Fixes #66 * fix(constants): redo verification keys Co-authored-by: ludamad <adam@aztecprotocol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The join_split circuit now skips signature verification for merge join_splits since It checks that the spender and total amounts are going to remain the same and that only note aggregation is happening.
However, using the account_required flag an exploiter that has control over an account key but no spending keys could still drain the notes that have account_required to
true
:false
false
The text was updated successfully, but these errors were encountered: