Prover constructs sumcheck #61

codygunton · 2023-01-12T20:06:15Z

This PR makes the Honk Prover class construct a sumcheck object and execute this. Some of the higher-level changes this necessitates.

It may be desirable to pre-compute sumcheck classes for some expected sizes (values of multivariate_d, but at least for now I make this size a runtime parameter. This necessitates replacing some uses of std::array with std::vector.
Since Standard Honk and Standard Plonk have different sets of polynomials, we cannot reuse the Standard Plonk polynomial manifest (or its size). The polynomial manifest is selected using the Composer type, so I added another composer type for Standard Honk.
I add a constructor of a Multivariates object from a proving key (needed for prover to create the object) and from a transcript (Sumcheck class in verifier mode had previously not constructed multivariates).

I regret leaving the insertion of the sumcheck evaluations in a rough form in the prover. This is done for expediency.

cpp/src/aztec/honk/composer/standard_honk_composer.test.cpp

cpp/src/aztec/honk/proof_system/prover.cpp

ledwards2225 · 2023-01-17T18:12:13Z

cpp/src/aztec/honk/sumcheck/polynomials/multivariates.hpp

+        }
+    };
+
+    explicit Multivariates(const std::shared_ptr<waffle::proving_key>& proving_key)


To be updated to handle shifted polynomials in follow-on

ledwards2225 · 2023-01-17T18:17:55Z

cpp/src/aztec/honk/sumcheck/sumcheck.test.cpp

@@ -70,7 +74,18 @@ TEST(Sumcheck, Prover)
        q_c, sigma_1, sigma_2, sigma_3, id_1,         id_2, id_3, lagrange_1
    };

-    auto transcript = Transcript(transcript::Manifest());
+    std::vector<transcript::Manifest::RoundManifest> manifest_rounds;


Follow-on: Stuff like this and mock_prover_contributions_to_transcript could be replaced with the real manifest and the mock_inputs_prior_to_challenge() fctn

Yeah, I think, more generally, we need to decide on a policy about when we use real things vs mocked things. @arijitdutta67 maybe you can keep this in mind as you work on the sumcheck tests and implement @ledwards2225's suggestion if you think it makes sense to do so?

cpp/src/aztec/honk/sumcheck/sumcheck_round.test.cpp

ledwards2225 · 2023-01-17T18:22:16Z

cpp/src/aztec/plonk/proof_system/types/polynomial_manifest.hpp

+    PolynomialDescriptor("W_2", "w_2_lagrange", false, false, WITNESS, W_2), //
+    PolynomialDescriptor("W_3", "w_3_lagrange", false, false, WITNESS, W_3), //
+    PolynomialDescriptor("Z_PERM", "z_perm", true, true, WITNESS, Z),        //
+    // PolynomialDescriptor("Z_PERM_SHIFT", "z_perm_shift", true, true, WITNESS, Z_LOOKUP),                     //


To be reinstated in follow-on

ledwards2225 · 2023-01-17T18:23:34Z

cpp/src/aztec/proof_system/flavor/flavor.hpp

@@ -11,7 +11,7 @@ struct StandardArithmetization {
        W_R,
        W_O,
        Z_PERM,
-        Z_PERM_SHIFT,
+        Z_PERM_SHIFT, // TODO(Cody): Hid ethis.


To be addressed in follow-on

ledwards2225 · 2023-01-17T18:26:28Z

cpp/src/aztec/proof_system/flavor/flavor.hpp

@@ -36,7 +36,8 @@ struct StandardHonk {
  public:
    using Arithmetization = proving_system::StandardArithmetization;
    using MULTIVARIATE = Arithmetization::POLYNOMIAL;
-    static constexpr size_t STANDARD_UNROLLED_MANIFEST_SIZE = 12; // cf waffle::STANDARD_UNROLLED_MANIFEST_SIZE
+    // TODO(Cody): Where to specify? is this polynomial manifest size?
+    static constexpr size_t STANDARD_HONK_MANIFEST_SIZE = 16;


Can this just be deleted? Not currently used anywhere. Or should the value be specified here then used by the polynomial manifest?

I left it in only as a comment, as a suggestion that perhaps this data should be specified as part of the flavor.

ledwards2225 · 2023-01-17T18:27:29Z

cpp/src/aztec/proof_system/flavor/flavor.hpp

            },
            /* challenge_name = */ "rho",
-            /* num_challenges_in = */ STANDARD_UNROLLED_MANIFEST_SIZE - 1, /* TODO(Cody): this is bad. */
+            /* num_challenges_in = */ 11, /* TODO(Cody): magic number! Where should this be specified? */


To be addressed in follow-on

ledwards2225 · 2023-01-17T18:28:53Z

cpp/src/aztec/honk/composer/composer_helper/composer_helper.cpp

@@ -233,6 +234,9 @@ std::shared_ptr<waffle::proving_key> ComposerHelper<CircuitConstructor>::compute

    compute_first_and_last_lagrange_polynomials(circuit_proving_key.get());

+    // TODO(Cody): this is a workaround


To be addressed in follow-on

* Hack poly mfst to get multivariates from pk. * d is not a template param * Prover executes sumcheck. * Address some comments from Luke.

codygunton self-assigned this Jan 12, 2023

codygunton force-pushed the cg/integrate-sumcheck branch from aa1307a to 771845c Compare January 13, 2023 19:13

codygunton added 5 commits January 17, 2023 15:35

Hack poly mfst to get multivariates from pk.

ce5e90e

Try to fix tests.

5cb7882

add comment

7046ccd

d is not a template param; fix test.

4461488

Prover executes sumcheck.

286c188

codygunton force-pushed the cg/integrate-sumcheck branch 3 times, most recently from 02fe345 to b0f7570 Compare January 17, 2023 16:35

Fix compliation, verifier test. Clean up.

4aac909

codygunton force-pushed the cg/integrate-sumcheck branch from c58872c to 4aac909 Compare January 17, 2023 17:31

codygunton requested a review from ledwards2225 January 17, 2023 17:59

codygunton marked this pull request as ready for review January 17, 2023 18:24

ledwards2225 approved these changes Jan 17, 2023

View reviewed changes

Address some comments from Luke.

812063d

codygunton merged commit ed5eecf into master Jan 17, 2023

codygunton deleted the cg/integrate-sumcheck branch January 17, 2023 19:05

dbanks12 pushed a commit that referenced this pull request Jan 26, 2023

Prover constructs sumcheck (#61)

03f892b

* Hack poly mfst to get multivariates from pk. * d is not a template param * Prover executes sumcheck. * Address some comments from Luke.

dbanks12 pushed a commit that referenced this pull request Jan 27, 2023

Prover constructs sumcheck (#61)

c8c744b

* Hack poly mfst to get multivariates from pk. * d is not a template param * Prover executes sumcheck. * Address some comments from Luke.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prover constructs sumcheck #61

Prover constructs sumcheck #61

codygunton commented Jan 12, 2023 •

edited

Loading

ledwards2225 Jan 17, 2023

ledwards2225 Jan 17, 2023

codygunton Jan 17, 2023

ledwards2225 Jan 17, 2023

ledwards2225 Jan 17, 2023

ledwards2225 Jan 17, 2023

codygunton Jan 17, 2023

ledwards2225 Jan 17, 2023

ledwards2225 Jan 17, 2023

		@@ -233,6 +234,9 @@ std::shared_ptr<waffle::proving_key> ComposerHelper<CircuitConstructor>::compute

		compute_first_and_last_lagrange_polynomials(circuit_proving_key.get());

		// TODO(Cody): this is a workaround

Prover constructs sumcheck #61

Prover constructs sumcheck #61

Conversation

codygunton commented Jan 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codygunton commented Jan 12, 2023 •

edited

Loading