Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minor increase in Pedersen generators for HIGH #619

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore: Minor increase in Pedersen generators for HIGH #619

merged 1 commit into from
Jul 20, 2023

Conversation

suyash67
Copy link
Contributor

@suyash67 suyash67 commented Jul 19, 2023 •
edited
Loading

Description

We need 48 generators for hashing in a3 instead of the current 44, for HIGH hash indices (i.e. hash_index ≥ 40).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@suyash67 suyash67 changed the title Minor increase in Pedersen generators for HIGH chore: Minor increase in Pedersen generators for HIGH Jul 19, 2023
ludamad
ludamad approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me pending no impact on Noir

@ludamad ludamad added the noir-ci Run the Noir CI label Jul 19, 2023
@suyash67
Copy link
Contributor Author

noir-ci is breaking on increasing the total Pedersen generators even slightly (from 776 to 792). This was the case even we reduced the total number of generators from ~2000 to 776 (PR #413). So I am merging this one to unblock pending nullifier work on packages.

@suyash67 suyash67 merged commit af91bc8 into master Jul 20, 2023
@suyash67 suyash67 deleted the sb/increase-ped-gen branch July 20, 2023 07:40
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
@suyash67
chore: Minor increase in Pedersen generators for HIGH (AztecProtoco…
97c9132 
…l/barretenberg#619)
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
@suyash67
chore: Minor increase in Pedersen generators for HIGH (AztecProtoco…
cfb4f59 
…l/barretenberg#619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees
No one assigned
Labels
noir-ci Run the Noir CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyash67 @ludamad