Constructing verification key #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
approved these changes
Jan 18, 2023
| @@ -257,6 +257,27 @@ TEST(standard_honk_composer, test_assert_equal) | |||
| EXPECT_EQ(get_maximum_cycle(composer_with_assert_equal), get_maximum_cycle(composer_no_assert_equal) * 2); | |||
| } | |||
|
|
|||
| TEST(standard_honk_composer, test_verification_key_creation) | |||
There was a problem hiding this comment.
Might be worth adding a few more comments to this test. Took me a second to determine what it's actually checking
dbanks12
pushed a commit
that referenced
this pull request
Jan 26, 2023
* Added verification key computation * Fixed test * Replaced constants * Added a comment that Luke wanted
dbanks12
pushed a commit
that referenced
this pull request
Jan 27, 2023
* Added verification key computation * Fixed test * Replaced constants * Added a comment that Luke wanted
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
* Added verification key computation * Fixed test * Replaced constants * Added a comment that Luke wanted
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
* Added verification key computation * Fixed test * Replaced constants * Added a comment that Luke wanted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the creation of verification key (basically, commitments to selectors and permutation polynomials)