Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update pages referencing macros #410

Closed
critesjosh opened this issue Oct 1, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8948
Closed

[docs] Update pages referencing macros #410

critesjosh opened this issue Oct 1, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#8948
Assignees

Comments

@critesjosh
Copy link
Collaborator

critesjosh commented Oct 1, 2024

Review existing pages

Aztec macros have changed as part of this PR

We need to do a pass of the docs and make sure that all of the references to macros follow the new convention. For example, this page is out of date.

Add blurb on Public calls

Also, an update to how public functions actually work (related to macros, source):

Contracts that include public functions (that is, marked with #[public]), are required to have a function public_dispatch(selector: Field) which acts as an entry point. This will be soon the only public function registered/deployed in contracts. The calling convention is updated so that external calls are made to this function.

If you are writing your contracts using Aztec-nr, there is nothing you need to change. The public_dispatch function is automatically generated by the #[aztec] macro.

catmcgee added a commit to AztecProtocol/aztec-packages that referenced this issue Oct 24, 2024
Closes AztecProtocol/dev-rel#410
closes: #6864
closes: AztecProtocol/dev-rel#417

Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.

---------

Co-authored-by: josh crites <jc@joshcrites.com>
Co-authored-by: James Zaki <james.zaki@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants