forked from spring-cloud-services-samples/acme-fitness-store
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable incremental product embedding #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Assist service: + Add a vectorstore, which doesn't calculate the embeddings when provided in the documents + Enable adding/updating documents + List the index out of date documents + Add a job to update the documents for some products - Update the source file of bikes.json and accessories.json to have id, which equals to the id of the product sql file, and the vector_store.json.
saragluna
approved these changes
May 28, 2024
xtreme-brian-shim
pushed a commit
to svrc/acme-fitness-store
that referenced
this pull request
Aug 22, 2024
* Adding Azure for Spring Developers full day workshop. * Adding content for Azure for Spring Developers full day workshop. * Fixed typo. * Added lab02. * Updated Lab02 * Added Lab03 * - Allow adding, editing, and deleting products - Update Assist service: + Add a vectorstore, which doesn't calculate the embeddings when provided in the documents + Enable adding/updating documents + List the index out of date documents + Add a job to update the documents for some products - Update the source file of bikes.json and accessories.json to have id, which equals to the id of the product sql file, and the vector_store.json. * Update ProductVo -> ProductValueObject * Remove files * Remove day sessions * Revert doc * Reverted code around ProductResponse * Add new product scripts * update * Rename OPENAI_APIKEY to OPENAI_API_KEY * remove bind operation --------- Co-authored-by: Neven Cvetkovic <neven.cvetkovic@gmail.com> Co-authored-by: Xiaolu Dai <xiada@microsoft.com> Co-authored-by: Xiaolu Dai <31124698+saragluna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command to deploy the job is like:
Steps to go through this change:
Update the Spring Cloud Gateway routing rules for catalog service, assist service.
Add a new product, you can enrich the short description and description
Update the product, this is optional
Deploy the assist-service, call the list product ids to index. You can see the newly added product is in the returned values.
curl --location 'https://xiada-fitness-store-gateway-fa329.svc.azuremicroservices.io/ai/admin/products-to-index'
Create and deploy the job, make sure setting the
BP_MAVEN_ACTIVE_PROFILES
envAdditional change is to unify parameter name SPRING_AI_AZURE_OPENAI_API_KEY and SPRING_AI_AZURE_OPENAI_APIKEY. Use SPRING_AI_AZURE_OPENAI_API_KEY as it is used by Spring AI doc.