Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing cache purge before token expires #457

Merged
merged 5 commits into from
Jan 30, 2021
Merged

Fixing cache purge before token expires #457

merged 5 commits into from
Jan 30, 2021

Conversation

jmprieur
Copy link
Contributor

Purpose

The serialized token cache should not be purged before the access token expires (otherwise the user will have to re-sign-in in a web app). However the SQL sliding expiry is 20 mins by default, whereas the token usually expire after 1h

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
    Run the the sample

Other Information

See also #115 (comment)

@jmprieur
Copy link
Contributor Author

@jennyf19 @bgavrilMS @trwalke @pmaytak @neha-bhargava @kalyankrishna1 @Shama-K
Please be aware of this condition

jmprieur and others added 2 commits January 30, 2021 18:23
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
Co-authored-by: jennyf19 <jeferrie@microsoft.com>
@jmprieur jmprieur merged commit 38c34a4 into master Jan 30, 2021
@jmprieur jmprieur deleted the SqlExpiry branch May 6, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants