Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to msalv2.0.1 #13

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Update to msalv2.0.1 #13

merged 1 commit into from
Sep 17, 2018

Conversation

jennyf19
Copy link
Contributor

Tested w/FB, Twitter, and Microsoft accounts (Google mult-auth was not redirecting back).
Can confirm that accounts are now deleted in relation to this MSAL issue and the MsalUiRequiredException is being thrown on the silent calls.

UpdateSignInState(false);
}
catch (MsalException ex)
while(accounts.Any())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while(accounts.Any()) [](start = 14, length = 22)

RemoveAccounts should be added to MSAL

Copy link

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 merged commit a6b7eff into master Sep 17, 2018
@jennyf19 jennyf19 deleted the jennyf/msalv2.0.1 branch September 17, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants