Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Telemetry #550

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Add Open Telemetry #550

merged 3 commits into from
Mar 27, 2024

Conversation

ross-p-smith
Copy link
Collaborator

@ross-p-smith ross-p-smith commented Mar 27, 2024

Purpose

Python is not configured to use the Open Telemetry library so I believe that this is the reason we are not seeing anything in Application Insights.

Fixes #547

After deploying I chatted with the Web App and this appears in AppInsights
image

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Do we start to see things in Application Insights!

Copy link

github-actions bot commented Mar 27, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code
   app.py1254266%30, 111, 150–151, 155, 158–159, 173–175, 177, 185, 189–193, 195, 202, 206–207, 213, 219–220, 222–223, 226, 240–241, 258, 260–261, 265, 274–278, 295, 297, 345–346
code/backend/batch
   function_app.py12120%1–6, 8, 10, 13–16
TOTAL163798040% 

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 10.422s ⏱️

@superhindupur
Copy link
Contributor

Surprising how the coverage percentage dropped by 15%

@ross-p-smith
Copy link
Collaborator Author

Surprising how the coverage percentage dropped by 15%

Because the tests failed :-)

@ross-p-smith ross-p-smith added this pull request to the merge queue Mar 27, 2024
Merged via the queue into main with commit c4f806d Mar 27, 2024
2 checks passed
@ross-p-smith ross-p-smith deleted the ross/opentelemetary branch March 27, 2024 18:04
eduardogch pushed a commit to devopsdale/chat-with-your-data-solution-accelerator that referenced this pull request Apr 30, 2024
* Add Open Telemetry

* Configure Azure Monitor when its called from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable logging for Azure Function
3 participants