Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all secrets are secure #9

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Make sure all secrets are secure #9

merged 1 commit into from
Mar 25, 2024

Conversation

pamelafox
Copy link
Contributor

Purpose

This PR removes security alerts caused by two issues- authClientSecret not being stored in secrets, and secrets not being marked as a secure input in the Bicep.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Deploy, log in
  • Run security scorecard, see no issues for secrets

@pamelafox pamelafox merged commit 2a6cbb5 into main Mar 25, 2024
3 checks passed
@pamelafox pamelafox deleted the secure-secrets branch March 25, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant