replace old private cluster scenario with avm, delete old scenarios #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#assign-reviewer: @iamaliyousefi |
iamaliyousefi
approved these changes
Sep 25, 2024
README.md
Outdated
| @@ -14,51 +14,15 @@ The AKS Landing Zone Accelerator is only concerned with what gets deployed in th | |||
|
|
|||
| ## Choosing a Deployment Model | |||
|
|
|||
| The reference implementations are spread across three repos that all build on top of the [AKS baseline reference architecture](https://learn.microsoft.com/azure/architecture/reference-architectures/containers/aks/baseline-aks) and Azure Landing Zones. | |||
| The reference implementations are spread across two repos that all build on top of the [AKS baseline reference architecture](https://learn.microsoft.com/azure/architecture/reference-architectures/containers/aks/baseline-aks) and Azure Landing Zones. | |||
There was a problem hiding this comment.
I'd rather use repositories, instead of repos here.
README.md
Outdated
| ### Follow a scenario driven tutorial within this repo | ||
|
|
||
| Pick one of the scenarios below to get started on a reference implementation. For the AKS secure baseline with non-private cluster, use the [AKS baseline](https://github.com/mspnp/aks-baseline) reference implementation. | ||
| 1. This one. To Deploy our AKS Secure Baseline Scenario, Check out [AKS Secure Baseline](./Scenarios/AKS-Secure-Baseline-PrivateCluster/). Use [this repo](https://github.com/Azure/AKS-Landing-Zone-Accelerator/tree/main/Scenarios/AKS-Secure-Baseline-PrivateCluster) if you would like step by step guidance on how to deploy secure and well architected AKS clusters using our scenario based model and/or you are new to AKS or IaC. This model promotes a separation of duties, modularized IaC so you can pick and choose components you want to build with your cluster and has implementations in ARM, Terraform and Bicep. It is the best starting point for people new to Azure or AKS. |
There was a problem hiding this comment.
Does "This one." mean anything in the 1st item? Unfortunately, I didn't get it, so I asked for clarification that if it adds nothing meaningful to the sentence, we can delete that phrase.
.vscode/cspell.json
Outdated
There was a problem hiding this comment.
in the ignoreWords line, all words are all in capital, except the outfile word.
iamaliyousefi
approved these changes
Sep 26, 2024
iamaliyousefi
approved these changes
Sep 26, 2024
iamaliyousefi
approved these changes
Sep 26, 2024
|
#assign:@iamaliyousefi |
iamaliyousefi
approved these changes
Sep 26, 2024
iamaliyousefi
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came together through the work done by @MattLeach25 , @deepdolphin and @mosabami. It effectively deprecates the old Private cluster scenario as well as some of the older scenarios and replaces them with the AVM scenario. Here are the changes:
New Private cluster scenario powered by AVM
The new Private cluster scenario leverages Azure Verified modules to help make it easier to maintain our work by decentralizing requirement to keep bicep modules up to date. It also includes an option to deploy the entire scenario all using a deploy to azure button, or running the az deployment sub command on 1 bicep file that leverages the underlying landing zone layers. It uses the new AKS store demo as its sample app which will be expanded upon in future modules.
Work remaining to be done
Update our CI/CD pipeline to use this new module
Add TLS to our deployment app deployment