Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Policy Refresh H2 FY24 and Changes for AMA #785

Merged
merged 55 commits into from
Jun 20, 2024

Conversation

cae-pr-creator[bot]
Copy link
Contributor

@cae-pr-creator cae-pr-creator bot commented Jun 3, 2024

Overview/Summary

This will be in our next major release and includes the policy refresh for H2 2024 and the necessary changes to move away from Microsoft Monitoring Agent to Azure Monitoring Agent.

Linked Work Items:

AB#34921
AB#22581

This PR fixes/adds/changes/removes

  1. Policy Refresh for H2 FY24
  2. AMA Changes/Updates
  3. Update Policy Assignments resource provider api version to 2024-04-01

Breaking Changes

  1. None

Testing Evidence

Validated deployment over the top of current release.

As part of this Pull Request I have

@oZakari oZakari self-assigned this Jun 5, 2024
@oZakari oZakari added the Area: Policy 📝 Issues / PR's related to Policy label Jun 5, 2024
@oZakari
Copy link
Contributor

oZakari commented Jun 17, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari requested a review from jtracey93 June 17, 2024 04:38
@oZakari oZakari marked this pull request as ready for review June 17, 2024 04:39
@oZakari oZakari changed the title Update Policy Library (automated) Enhancement: Policy Refresh H2 FY24 Jun 17, 2024
@oZakari
Copy link
Contributor

oZakari commented Jun 20, 2024

@oZakari This is amazing work, must have taken some serious effort!

I added a few comments and these more general questions:

Are we missing a policy assignment for blocking deletion of the UAMI? https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/blob/main/modules/archetypes/lib/policy_assignments/policy_assignment_es_denyaction_deleteuamiama.tmpl.json

I'm also looking at the other new policy assignments we synced to Terraform and not seeing them all here. You can look at this diff to see them: Azure/terraform-azurerm-caf-enterprise-scale@5.2.1-fixes...main

Thanks, I was missing the Delete-UAMI one.

@oZakari
Copy link
Contributor

oZakari commented Jun 20, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jtracey93 jtracey93 merged commit 925a4ef into main Jun 20, 2024
11 checks passed
@jtracey93 jtracey93 deleted the patch-policy-library branch June 20, 2024 15:39
@oZakari oZakari changed the title Enhancement: Policy Refresh H2 FY24 Enhancement: Policy Refresh H2 FY24 and Changes for AMA Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants