-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init vuln-to-kusto step #4554
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 9674497628Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9703441831Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9785288967Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9785289030Details
💛 - Coveralls |
scriptLocation: 'inlineScript' | ||
inlineScript: | | ||
export AZCOPY_AUTO_LOGIN_TYPE=AZCLI | ||
azcopy copy https://vulntokustobinary.blob.core.windows.net/vuln-to-kusto/v0.0.1-ee36fabc1ec4f415a022042ea89f751bf05da6ef/vuln-to-kusto-vhd_Linux_x86_64 ./vuln-to-kusto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this storage is locked down? does that mean we're already able to pull from it using the agent identity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep the storage account is private and configured to be accessible with the identity used in this step (agentbaker-vuln-to-kusto
)
Pull Request Test Coverage Report for Build 9871536617Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for now, feel free to ping me for a further review if you need it
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: