-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: remove kube-proxy-images.json #4556
Conversation
Pull Request Test Coverage Report for Build 9687522233Details
💛 - Coveralls |
8eb3a1f
to
28cc2a0
Compare
Pull Request Test Coverage Report for Build 9687550537Details
💛 - Coveralls |
28cc2a0
to
c882aab
Compare
Pull Request Test Coverage Report for Build 9687655292Details
💛 - Coveralls |
@@ -381,6 +381,29 @@ | |||
"multiArchVersions": [ | |||
"v0.7.1" | |||
] | |||
}, | |||
{ | |||
"downloadURL": "mcr.microsoft.com/oss/kubernetes/kube-proxy:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem like we're actually using this during VHD builds (install-dependencies.sh), are we not supposed to be caching this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed offline that we still aim to cache this, should probably wait on merging this until after @Devinwong's change merge into master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this loop https://github.com/Azure/AgentBaker/pull/4556/files#diff-d6aeb8e845af4c32251915a17dc7c887d73cd628262e83118b9dcd65f7728c98L312-R343 cover the added json entry under 'containerImages' key? I couldn't properly check b/c test pipeline was failing for other reasons, but I'll confirm once that's unblocked. I can also just pause until schema's finalized as you suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes you're right :)
approved, up to you whether you wanna merge now before Devin's changes or wait until the schema is updated
Pull Request Test Coverage Report for Build 9716172770Details
💛 - Coveralls |
816bf11
to
b527914
Compare
Pull Request Test Coverage Report for Build 9748402800Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9753410800Details
💛 - Coveralls |
{ | ||
"downloadURL": "mcr.microsoft.com/oss/kubernetes/kube-proxy:*", | ||
"amd64OnlyVersions": [], | ||
"multiArchVersions": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's way too may version. after we review the Schema, we will need to keep 3 images only (one per AKS versions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll need to keep corresponding kube-proxy version for each unique major.minor.patch k8s version
ad87a70
to
7c70b35
Compare
Pull Request Test Coverage Report for Build 9814673025Details
💛 - Coveralls |
7c70b35
to
2d9b631
Compare
Pull Request Test Coverage Report for Build 9961922027Details
💛 - Coveralls |
2d9b631
to
d7de5d9
Compare
d7de5d9
to
52e2b3a
Compare
52e2b3a
to
e988c7f
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
remove kube-proxy-image.json
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: