-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: enable shallow replication #4586
Open
zachary-bailey
wants to merge
83
commits into
master
Choose a base branch
from
zacharybailey/enableShallowReplicationToggle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf: enable shallow replication #4586
zachary-bailey
wants to merge
83
commits into
master
from
zacharybailey/enableShallowReplicationToggle
+92
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9783868032Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9783881983Details
💛 - Coveralls |
b2e1736
to
d39d974
Compare
d39d974
to
42ba1a9
Compare
Pull Request Test Coverage Report for Build 9783951092Details
💛 - Coveralls |
vhdbuilder/packer/convert-sig-to-classic-storage-account-blob.sh
Outdated
Show resolved
Hide resolved
42ba1a9
to
9656c5b
Compare
386b812
to
1ddf82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind perf
What this PR does / why we need it:
This PR enables the use of shallow replication in all VHD build pipelines in order to reduce feedback time / increase productivity. Enabling shallow replication decreases pipeline duration by 10-13 minutes depending on the run. Averages derived from 3 runs from master and 3 from this branch.
This is accomplished by installing the azure-arm plugin for packer, which enables the use of shallow replication.
Which issue(s) this PR fixes:
Unsatisfactory VHD Build Times.
Requirements: