Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run e2e after build and combine two ADO pipelines #4609

Closed
wants to merge 25 commits into from
Closed

Conversation

r2k1
Copy link
Contributor

@r2k1 r2k1 commented Jul 9, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9883352741

Details

  • 68 of 119 (57.14%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 70.486%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apiserver/routers.go 0 6 0.0%
apiserver/getcachedvhdimages.go 0 17 0.0%
pkg/agent/vhd/cache/cache.go 65 93 69.89%
Totals Coverage Status
Change from base Build 9881917052: -0.4%
Covered Lines: 2627
Relevant Lines: 3727

💛 - Coveralls

branches:
include:
- master
trigger: none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad rebase ? I though this was added recently ?

@@ -200,12 +200,6 @@ steps:
artifactName: 'vhd-image-bom-${{ parameters.artifactName }}'
targetPath: 'image-bom.json'
displayName: publish container image list
- task: PublishPipelineArtifact@1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad rebase ? I think Zach added that recently

@@ -237,7 +237,7 @@ func getBaseVMSSModel(name, sshPublicKey, customData, cseCmd string, opts *scena
Properties: &armcompute.VirtualMachineScaleSetProperties{
Overprovision: to.Ptr(false),
UpgradePolicy: &armcompute.UpgradePolicy{
Mode: to.Ptr(armcompute.UpgradeModeAutomatic),
Mode: to.Ptr(armcompute.UpgradeModeManual),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong rebase.

@@ -27,8 +27,7 @@
"amd64OnlyVersions": [],
"multiArchVersions": [
"v1.9.4-hotfix.20240520",
"v1.9.4-hotfix.20240627",
"v1.9.4-hotfix.20240704"
"v1.9.4-hotfix.20240627"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong rebase ?

@@ -169,7 +168,7 @@
"downloadURL": "mcr.microsoft.com/azuremonitor/containerinsights/ciprod:*",
"amd64OnlyVersions": [],
"multiArchVersions": [
"3.1.22"
"3.1.21"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong rebase

@r2k1 r2k1 closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants