-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install oras on the VHD #4615
Conversation
Pull Request Test Coverage Report for Build 10049773120Details
💛 - Coveralls |
@@ -165,6 +165,10 @@ if [[ $OS == $MARINER_OS_NAME ]]; then | |||
activateNfConntrack | |||
fi | |||
|
|||
# installs oras for installing packages for network isolated clusters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO code changes here, to get an idea of what will need to be done for NIC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cse_main.sh and install-dependencies.sh both call installDeps
, thus this shouldn't be necessary
you could also keep it separate from installDeps
and call installOras
here like you're doing, as well as within cse_main.sh
, instead of adding it directly within installDeps
, which is what I'd personally prefer as that's already what we do for most things that aren't system packages
either way you should also make sure installOras
is idempotent, in that it doesn't actually download anything over the wire when oras is already installed
…Baker into alburgess/cache-oras
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: