feat: install oras on the VHD #4615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10049773120Details
💛 - Coveralls |
AlisonB319
commented
Jul 11, 2024
| @@ -165,6 +165,10 @@ if [[ $OS == $MARINER_OS_NAME ]]; then | |||
| activateNfConntrack | |||
| fi | |||
|
|
|||
| # installs oras for installing packages for network isolated clusters | |||
There was a problem hiding this comment.
TODO code changes here, to get an idea of what will need to be done for NIC
There was a problem hiding this comment.
cse_main.sh and install-dependencies.sh both call installDeps, thus this shouldn't be necessary
you could also keep it separate from installDeps and call installOras here like you're doing, as well as within cse_main.sh, instead of adding it directly within installDeps, which is what I'd personally prefer as that's already what we do for most things that aren't system packages
either way you should also make sure installOras is idempotent, in that it doesn't actually download anything over the wire when oras is already installed
AlisonB319
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
djsly
reviewed
Jul 11, 2024
…Baker into alburgess/cache-oras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: