-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests to check content of sources.list #4628
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 9960884651Details
💛 - Coveralls |
sourcesListPath="/etc/apt/sources.list" | ||
searchWord="snapshot" | ||
# This file should always exist on any Ubuntu node, however, still check its existence for sanity | ||
if test -f "${sourcesListPath}"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we err if this file doesn't exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the test wants to ensure that the file doesn't content any snapshot references., so if there file doesnt' exist it should be fine.
If we believe this file should always be present I would add another test which verify for this explicitly.
What type of PR is this?
This PR adds a test to post content VHD build to ensure that in case VHD is built from an official branch, any snapshot references don't exist in the /etc/apt/sources.list
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: