test: Improve e2e tests #4631
test: Improve e2e tests #4631
Conversation
r2k1
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
e2e/cluster.go
Outdated
| return VNet{}, fmt.Errorf("failed to find aks vnet") | ||
| } | ||
|
|
||
| func collectGarbageVMSS(ctx context.Context, cluster *armcontainerservice.ManagedCluster) error { |
| Model *armcontainerservice.ManagedCluster | ||
| Kube *Kubeclient | ||
| SubnetID string | ||
| NodeBootstrappingConfiguration *datamodel.NodeBootstrappingConfiguration |
Pull Request Test Coverage Report for Build 9966466119Details
💛 - Coveralls |
e2e/scenario_test.go
Outdated
| }) | ||
| } | ||
|
|
||
| func getContainerdManifestVersion() string { |
e2e/vmss.go
Outdated
| return nil, fmt.Errorf("begin create VMSS %q: %w", vmssName, err) | ||
| var respErr *azcore.ResponseError | ||
| // sometimes the SKU is not available and we can't do anything. Skip the test in this case. | ||
| if config.SkipTestsWithSKUCapacityIssue && errors.As(err, &respErr) && respErr.StatusCode == 409 && respErr.ErrorCode == "SkuNotAvailable" { |
There was a problem hiding this comment.
extract logic to check for SkuNotAvailable to a helper to make this a bit more readable?
| nbc.ContainerdVersion = "1.6.9" | ||
| }, | ||
| LiveVMValidators: []*LiveVMValidator{ | ||
| containerdVersionValidator(getContainerdManifestVersion()), |
There was a problem hiding this comment.
oh, I didn't change this test yet. Now the containerd version should always come from components.json. I haven't removed the containerd version from manifest.json yet.
Feel free to change it or I will do that after your PR get merged.
| nbc.AgentPoolProfile.Distro = "aks-azurelinux-v2-arm64-gen2" | ||
| nbc.IsARM64 = true | ||
| }, | ||
| VMConfigMutator: func(vmss *armcompute.VirtualMachineScaleSet) { |
There was a problem hiding this comment.
maybe in a follow-up you can rename VMConfigMutator to VMSSModelMutator to make it a bit more clear?
| nbc.AgentPoolProfile.Distro = "aks-azurelinux-v2-gen2" | ||
| }, | ||
| LiveVMValidators: []*LiveVMValidator{ | ||
| serviceCanRestartValidator("chronyd", 10), |
There was a problem hiding this comment.
maybe something else you can look at, let's have validators either consistently be exported or unexported, not a mixture of both
fine with just having them be unexported since we've moved them to the e2e package at this point
| nbc.ContainerService.Properties.AgentPoolProfiles[0].Distro = "aks-ubuntu-containerd-22.04-gen2" | ||
| nbc.AgentPoolProfile.VMSize = vmSize | ||
| nbc.AgentPoolProfile.Distro = "aks-ubuntu-containerd-22.04-gen2" | ||
| nbc.ConfigGPUDriverIfNeeded = true |
There was a problem hiding this comment.
another example I think where helpers would be beneficial for ease of test authorship,
e.g. WithGPUDriverInstallation
Better integration with IDE. Easier to debug a single test
Easier to follow the test logic. Execution sequence is more straightforward.
t.Loginstead oflog.Print. Group logs by test, helps with log mixing due to parallel test execution