fix: capture_benchmark function fix for component downloads #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
ShiqianTao,
AbelHu,
junjiezhang1997,
jason1028kr and
djsly
as code owners
zachary-bailey
changed the title
Pull Request Test Coverage Report for Build 9974903105Details
💛 - Coveralls |
Devinwong
approved these changes
Jul 15, 2024
| @@ -413,7 +413,10 @@ check_array_size() { | |||
|
|
|||
| capture_benchmark() { | |||
| set +x | |||
| benchmarks+=($1) | |||
There was a problem hiding this comment.
for future reference, let's avoid using parameters directly within logic, e.g. always assign to a local variable to give the parameter a meaningful name before using elsewhere within the function/script.
cameronmeissner
approved these changes
Jul 15, 2024
zachary-bailey
force-pushed
the
zacharybailey/benchmarksFixForPlugins
branch
from
cda5954
to
f4bd155
Compare
zachary-bailey
force-pushed
the
zacharybailey/benchmarksFixForPlugins
branch
from
6be7614
to
8237de1
Compare
zachary-bailey
force-pushed
the
zacharybailey/benchmarksFixForPlugins
branch
from
8237de1
to
6125936
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR enables the
capture_benchmarkfunction to handle arguments that contain whitespaces and hyphens. The code change results in these characters being converted into underscores and the function successfully continuing.Which issue(s) this PR fixes:
Benchmarks for the install-dependencies.sh script are not currently available because some new variable names contain hyphens which is breaking the function.
Requirements: