-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: capture_benchmark function fix for component downloads #4652
Conversation
Pull Request Test Coverage Report for Build 9974903105Details
💛 - Coveralls |
@@ -413,7 +413,10 @@ check_array_size() { | |||
|
|||
capture_benchmark() { | |||
set +x | |||
benchmarks+=($1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future reference, let's avoid using parameters directly within logic, e.g. always assign to a local variable to give the parameter a meaningful name before using elsewhere within the function/script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do!
cda5954
to
f4bd155
Compare
6be7614
to
8237de1
Compare
8237de1
to
6125936
Compare
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR enables the
capture_benchmark
function to handle arguments that contain whitespaces and hyphens. The code change results in these characters being converted into underscores and the function successfully continuing.Which issue(s) this PR fixes:
Benchmarks for the install-dependencies.sh script are not currently available because some new variable names contain hyphens which is breaking the function.
Requirements: