test: initial powershell test for windows nodes #5635
Merged
+205
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
zachary-bailey
as code owners
timmy-wright
force-pushed
the
timmy/windows-tests
branch
from
6968777 to
4fa56d1
Compare
timmy-wright
force-pushed
the
timmy/windows-tests
branch
from
705356e to
946a766
Compare
timmy-wright
force-pushed
the
timmy/windows-tests
branch
from
4c8b14c to
c7b985f
Compare
r2k1
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What this PR does / why we need it:
This PR adds some e2e tests for Windows VHDs and some infrastructure code to execute arbitrary commands on a windows VHD as part of the e2e tests. It's got some - currently unused - code to check kubelet command line params as well, that's still in progress, but I want it checked in so I don't loose it.
Note that to do this, I had to change the execOnVm method to not add "sudo" to every command executed on the VM. That broke Windows tests because sudo is not a powershell command. Now the sudo is part of each test - which is probably cleaner. It seems that some existing linux tests prob didn't need to run sudo, but I didn't want to check each one just in case it was necessary.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: