Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What-If to output raw Json #381

Merged
merged 3 commits into from
Jul 12, 2021
Merged

What-If to output raw Json #381

merged 3 commits into from
Jul 12, 2021

Conversation

Gordonby
Copy link
Contributor

@Gordonby Gordonby commented Jul 9, 2021

Introduced a new function to output both MD and JSON files

@Gordonby Gordonby requested a review from a team as a code owner July 9, 2021 12:36
@Gordonby
Copy link
Contributor Author

Gordonby commented Jul 9, 2021 •
edited
Loading

@ljtill - used the VSCode dev container route as suggested to test this before PR. 😄

🚀

ljtill
ljtill reviewed Jul 12, 2021
View reviewed changes
Copy link
Member

@ljtill ljtill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @Gordonby 👍

Before merging, please can we update the Strings.psd1 to include the logging messages for the Write-PSFMessage cmdlets.

Path: src/localized/en-us/Strings.psd1

@Gordonby
Copy link
Contributor Author

Ok @ljtill - hadn't seen the loc 👍
done. 🚀

ljtill
ljtill approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@ljtill ljtill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljtill ljtill merged commit bc6aa65 into Azure:main Jul 12, 2021
@ljtill ljtill added this to the Release - v1.3.0 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljtill ljtill ljtill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release - v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gordonby @ljtill