Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new def convert #21

Merged
merged 22 commits into from
Jul 3, 2024
Merged

feat: new def convert #21

merged 22 commits into from
Jul 3, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Jul 2, 2024 •
edited
Loading

  • moves policy & policy set def sync to alzlibtool due to issues with the pwsh version not creating valid resource ids for things
  • adds in a pr-check to scan library changes

The change to alzlibtool has caused a not very nice diff with the policy files. This will be a one time problem.

@matt-FFFFFF matt-FFFFFF requested a review from a team as a code owner July 2, 2024 15:54
@matt-FFFFFF matt-FFFFFF requested a review from jaredfholgate July 3, 2024 12:37
jaredfholgate
jaredfholgate approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything obvious. LGTM

@matt-FFFFFF matt-FFFFFF merged commit 62ae5fa into main Jul 3, 2024
3 checks passed
@matt-FFFFFF matt-FFFFFF deleted the feat/newDefConvert branch July 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-FFFFFF @jaredfholgate