Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alz): missing and incorrect defaults #80

Merged
merged 10 commits into from
Oct 28, 2024
Merged

fix(alz): missing and incorrect defaults #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
afe242f
fix(alz): deploy-diag-logcat rename, fixes #78
matt-FFFFFF Oct 25, 2024
e76c9bc
fix(alz): add missing private dns zones to list of defaults. fixes #79
matt-FFFFFF Oct 25, 2024
bd21a57
fix:(alz) remove old default value
matt-FFFFFF Oct 25, 2024
5595c4c
ci: migrate to alzlibtool binary dist
matt-FFFFFF Oct 27, 2024
1fa168a
ci: migrate to alzlibtool binary dist
matt-FFFFFF Oct 27, 2024
aa56467
ci: add missing z flag to tar
matt-FFFFFF Oct 27, 2024
69bf448
ci: fix dist binary
matt-FFFFFF Oct 27, 2024
56b6e0e
doc(alz): gen docs
matt-FFFFFF Oct 27, 2024
528574a
feat: update alzlib 0.22.1
matt-FFFFFF Oct 28, 2024
6ce5c58
ci: fix tool url
matt-FFFFFF Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/pr-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ on:
- main
workflow_dispatch:

env:
alzlibtool_version: "0.22.1"

jobs:
libschanged:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -48,17 +51,14 @@ jobs:
matrix:
lib: ${{ fromJson(needs.libschanged.outputs.list) }}
steps:
- name: Install alzlibtool
run: |
curl -L https://github.com/Azure/alzlib/releases/download/v${{ env.alzlibtool_version }}/alzlibtool_linux_amd64.tar.gz | tar -xvz
sudo cp alzlibtool /usr/local/bin

- name: Checkout code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- name: Set up go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
with:
go-version: 'stable'

- name: Install alzlibtool
run: go install github.com/Azure/alzlib/cmd/alzlibtool@v0.21.7

- name: Azure login
uses: azure/login@6c251865b4e6290e7b78be643ea2d005bc51f69a # v2.1.1
with:
Expand Down
14 changes: 6 additions & 8 deletions .github/workflows/update-alz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ permissions:
contents: write

env:
alzlibtool_version: "0.22.0"
remote_repository: "Azure/Enterprise-Scale"
alzlib_repository: "Azure/alzlib"
library_dir: "platform/alz"
Expand All @@ -25,6 +26,11 @@ jobs:
runs-on: ubuntu-latest
environment: libupdate
steps:
- name: Install alzlibtool
run: |
curl -L https://github.com/Azure/alzlib/releases/download/v${{ env.alzlibtool_version }}/alzlib_0.22.0_linux_amd64.tar.gz | tar -xvz
sudo cp alzlibtool /usr/local/bin

- name: Local repository checkout
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
Expand All @@ -38,14 +44,6 @@ jobs:
path: ${{ env.remote_repository }}
ref: main

- name: setup go
uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
with:
go-version: 'stable'

- name: install alzlibtool
run: go install github.com/Azure/alzlib/cmd/alzlibtool@v0.21.7

- uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2.1.0
id: generate-token
with:
Expand Down
86 changes: 80 additions & 6 deletions platform/alz/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,32 +545,70 @@ The following policy default values are available in this library:
- logAnalyticsWorkspaceId
</details>

#### assignment `Deploy-Diag-Logs`
#### assignment `Deploy-Diag-LogsCat`

<details><summary>1 parameter names</summary>

- logAnalytics
</details>

#### assignment `Deploy-MDFC-Config`
#### assignment `Deploy-MDFC-Config-H224`

<details><summary>1 parameter names</summary>

- logAnalytics
</details>

#### assignment `Deploy-MDFC-Config-H224`
#### assignment `Deploy-MDFC-DefSQL-AMA`

<details><summary>1 parameter names</summary>

- logAnalytics
- userWorkspaceResourceId
</details>

#### assignment `Deploy-MDFC-DefSQL-AMA`
### default name `private_dns_bot_service`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- userWorkspaceResourceId
- azureBotServicePrivateDnsZoneId
</details>

### default name `private_dns_databricks`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureDatabricksPrivateDnsZoneId
</details>

### default name `private_dns_iot_central`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureIotCentralPrivateDnsZoneId
</details>

### default name `private_dns_iot_device_update`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureIotDeviceupdatePrivateDnsZoneId
</details>

### default name `private_dns_zone_acr`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureAcrPrivateDnsZoneId
</details>

### default name `private_dns_zone_app`
Expand Down Expand Up @@ -825,6 +863,15 @@ The following policy default values are available in this library:
- azureMachineLearningWorkspacePrivateDnsZoneId
</details>

### default name `private_dns_zone_machine_learning_workspace_second`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureMachineLearningWorkspaceSecondPrivateDnsZoneId
</details>

### default name `private_dns_zone_managed_grafana_workspace`

#### assignment `Deploy-Private-DNS-Zones`
Expand Down Expand Up @@ -942,6 +989,15 @@ The following policy default values are available in this library:
- azureSignalRPrivateDnsZoneId
</details>

### default name `private_dns_zone_site_recovery_backup`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureSiteRecoveryBackupPrivateDnsZoneID
</details>

### default name `private_dns_zone_site_recovery_blob`

#### assignment `Deploy-Private-DNS-Zones`
Expand Down Expand Up @@ -1041,6 +1097,24 @@ The following policy default values are available in this library:
- azureStorageStaticWebSecPrivateDnsZoneId
</details>

### default name `private_dns_zone_storage_table`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureStorageTablePrivateDnsZoneId
</details>

### default name `private_dns_zone_storage_table_secondary`

#### assignment `Deploy-Private-DNS-Zones`

<details><summary>1 parameter names</summary>

- azureStorageTableSecondaryPrivateDnsZoneId
</details>

### default name `private_dns_zone_synapse_dev`

#### assignment `Deploy-Private-DNS-Zones`
Expand Down
Loading