Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform/alz)!: add simplified private dns defaults and improve documentation #85

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

matt-FFFFFF
Copy link
Member

@matt-FFFFFF matt-FFFFFF commented Nov 6, 2024

Adds new default values for private link DNS zones and improves documentation for the platform/alz library.

Removed old per-zone defaults.

jaredfholgate
jaredfholgate previously approved these changes Nov 6, 2024
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion.

platform/alz/alz_policy_default_values.json Outdated Show resolved Hide resolved
@matt-FFFFFF matt-FFFFFF changed the title feat(platform/alz): add simplified private dns defaults and improve documentation feat!(platform/alz): add simplified private dns defaults and improve documentation Nov 6, 2024
@matt-FFFFFF matt-FFFFFF changed the title feat!(platform/alz): add simplified private dns defaults and improve documentation feat(platform/alz)!: add simplified private dns defaults and improve documentation Nov 6, 2024
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matt-FFFFFF matt-FFFFFF merged commit 266ad39 into main Nov 6, 2024
2 checks passed
@matt-FFFFFF matt-FFFFFF deleted the platform-alz-146 branch November 6, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants