Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware SD-WAN and SASE Solution v1.0.0 #9750

Merged
merged 47 commits into from
Mar 14, 2024
Merged

Conversation

stlaszlo
Copy link
Contributor

Change(s):

Added new solution: VMware SD-WAN and SASE (v1.0.0)
Included Function App for VMware Edge Cloud Orchestrator API integration
Included Analytics Rules for VMware SD-WAN and SASE
Included Hunting Queries for VMware SD-WAN and SASE
Included Workbook for VMware SD-WAN and SASE
Reason for Change(s):

New Solution Added
Version Updated:

No
Testing Completed:

Yes
Checked that the validations are passing and have addressed any issues that are present:

Need Help

stlaszlo and others added 27 commits November 26, 2023 12:27
The first update to include VMware SASE and SD-WAN connector into Azure Sentinel.
Fixed archive link
Added Readme
Fixed Storage Account references in the ARM template.
Pull request ready release:
-Fixed table names in Workbook
-Fixed table names in Analytics Rules
-Fixed table names in Hunting Queries
-Fixed Azure ARM template to deploy Function App from ZIP archive.
Added reference documentation.
Custom Table data added for pipeline testing.
Pipeline test fixes:
- Removed title tag from SVG logo image
- Removed obsolete custom table file
- Fixed CWS DLP violation Analytics rule
Added:
RequiredDataConnector, ConnectorId and dataType config to rule descriptors.
Minor fixes on the back of Azure Pipelines tests, MITRE tactic update, missing required connector settings, and added "VMwareSASE" to known connector IDs.
Remove entity mappings over the limit for the CWS Policy violation rule.
Added information for solution packaging as requested.
Updated the data connector scripts:
1. Removed unused branches (each script had instructions for every event type, now each script contains instructions for its own event type only
2. Cleaned up EFS-related defs from other scripts, moved global state array to initialize to sanitize EFS script
3. Fixed a number of other CodeQL flags such as variable use, format sanitization, etc.
Minor updates as requested:
1. Fixed the directory structure
2. Updated the archive to reflect directory changes
3. Connector file added
@stlaszlo stlaszlo requested review from a team as code owners January 10, 2024 16:05
@v-prasadboke
Copy link
Contributor

Hello @stlaszlo,
I have added python packages in the zip which were mentioned in requirements.txt
Please add more if required.

@v-prasadboke
Copy link
Contributor

Also can you provide me credentials to test function app
you can mail me them at v-prasadboke@microsoft.com

@stlaszlo
Copy link
Contributor Author

@v-prasadboke sent credentials via email with some instructions, but should you need anything, please let me know, I am happy to push this through the finish line.

@v-prasadboke
Copy link
Contributor

Hello @stlaszlo, can you share working images of function app

@v-prasadboke
Copy link
Contributor

Hello @stlaszlo,
There's an issue with analytic rule count. In analytic blade there shows no results for these 3 Analytic rules.

  1. VMware SD-WAN Edge - Device Congestion Alert - Packet Drops
  2. VMware SD-WAN Edge - IDS/IPS Signature Update Succeeded
  3. VMware SD-WAN Edge - IDS/IPS Signature Update Failed
image

While we can see them in the Solution details
image

aggregationKind: SingleAlert
customDetails:
Edge_SerialNr: edgeSerialNumber
sentinelEntitiesMappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @stlaszlo, Im not getting this sentinelEntitiesMappings
You can entity mappings over here

alertDynamicProperties: []
customDetails:
idpsSignatureVersion: idpsSignatureVersion
sentinelEntitiesMappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same is the case here

alertDynamicProperties: []
customDetails:
idpsSignatureVersion: idpsSignatureVersion
sentinelEntitiesMappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over here too

@v-prasadboke
Copy link
Contributor

The analytic rules mentioned above are the ones which are not visible in the Content Hub.

@stlaszlo
Copy link
Contributor Author

@v-prasadboke I will have a look tomorrow as I am on MWC. Thanks for the updates.

@v-prasadboke
Copy link
Contributor

Ok Thanks @stlaszlo.

@v-prasadboke
Copy link
Contributor

Hello @stlaszlo, Any updates on the above

stlaszlo added 2 commits March 6, 2024 14:27
Removed stuck Sentinel Entities mapping and replaced them with custom mappings for Edge Serial Number.
@stlaszlo
Copy link
Contributor Author

stlaszlo commented Mar 6, 2024

Hi @v-prasadboke

  1. Analytics rule fixes: I had to read up on documentation to see what was wrong, some test config got stuck, now I removed Sentinel Entity mappings and moved them to custom entity maps. I've pushed the fix.
  2. Funtion App screenshots: do I need to send these over via email or put them into a folder in the connector?

@v-prasadboke
Copy link
Contributor

You can share it over here

@stlaszlo
Copy link
Contributor Author

stlaszlo commented Mar 8, 2024

Hi @v-prasadboke I have attached a ZIP archive of screenshots, I am not sure what are you after, but I've tried attaching screenshots from the App Insights showing logs of successful event retrieval.

One thing to note is that I've done a clean deployment, application files are populated in VS Code, but the functions blade is empty. I've attached a working screenshot (function app name starts with laszlo-) and the new deployment. Could you please check the ZIP archive contents and let me know if I've named the files correctly?
functionapp_screenshots.zip

@v-prasadboke
Copy link
Contributor

Hello @stlaszlo, unable to pull latest commits to my local.
Will get back to you by 13 March, 2024.
Can you confirm once if I'm in the contributor list.

@stlaszlo
Copy link
Contributor Author

Hey @v-prasadboke,

Sure, thanks. Yes, you are still a contributor:
image

@v-atulyadav v-atulyadav merged commit 9726b80 into Azure:master Mar 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants