Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytic Rule "requiredDataConnectors" property should be [] in maintemplate and handle ARM-TTK Error #9789

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

v-amolpatil
Copy link
Contributor

@v-amolpatil v-amolpatil commented Jan 19, 2024

Required items, please complete

Change(s):

  • For analytic rules we are changing "requiredDataConnectors" value if [] in source then in maintemplate also it should come as [] without making use of json[].
  • Also, added skip validation for armttk in Github pipeline to skip if we get "Template should not contain blanks" error for "requiredDataConnectors" property. -- reverted code for this as pr for arm-ttk is approved and is merged so we dont need this.

Reason for Change(s):

  • Specified above

Version Updated:

  • NA

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

Maintemplate for Apache Log4j Vulnerability Detection solution has source file "requiredDataConnectors" value as [] which is the expected output as shown below:
image

@v-amolpatil v-amolpatil self-assigned this Jan 19, 2024
@v-amolpatil v-amolpatil marked this pull request as ready for review January 19, 2024 08:42
@v-amolpatil v-amolpatil requested review from a team as code owners January 19, 2024 08:42
Tichandr
Tichandr previously approved these changes Jan 22, 2024
@v-amolpatil v-amolpatil merged commit 9b6968b into master Feb 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants