Add catch around Delete Service invocation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenavillamil
requested review from
a team,
Tatsinnit and
sabbour
as code owners
hsubramanianaks
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is breaking changes between different version of kubernetes if client and server diverge enough. 1.21 and 1.22 DeleteService returns v1.Status (6.0 client sdk) while in 1.23, DeleteService returns v1.Service (7.0+ client sdk). Related issue with more details. We can control the client since it comes with bridge code (aka c# library), but we cannot control the server aka kubernetes version in the cluster. Thus exception handling is needed.
This will solve #90 and #55