Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac arm64 build #346

Merged
merged 23 commits into from
Jan 9, 2024
Merged

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Dec 14, 2023

This PR fixes

this change is to fix the user's issue. There will be a follow up PR to enhance or make the build scripts more readable and maintainable.

@credo7
Copy link

credo7 commented Dec 19, 2023

Hello, when are you planning to push it?

@hsubramanianaks
Copy link
Collaborator Author

Hello, when are you planning to push it?

@credo7 hi still working on it, I will keep you posted on it. Thanks

@hsubramanianaks hsubramanianaks marked this pull request as ready for review December 20, 2023 22:11
@hsubramanianaks
Copy link
Collaborator Author

hsubramanianaks commented Dec 20, 2023

Hello, when are you planning to push it?

@credo7 Can you help me test this vsix with your m1 mac? I verified myself, works fine. Here is the link to download the VSIX. Please set env variable before launching vscodeexport BRIDGE_ENVIRONMENT=dev for the VSIX to download the binaries successfully.

Tatsinnit
Tatsinnit previously approved these changes Dec 20, 2023
@Tatsinnit
Copy link
Member

Tatsinnit commented Dec 20, 2023

❤️☕️💡Thank you so much for this, looks good to me, please make sure, there is not side effect in larger scale for this. I take that you have done due diligence or we will get his tested before release in case we are not 100 % sure.

@hsubramanianaks
Copy link
Collaborator Author

❤️☕️💡Thank you so much for this, looks good to me, please make sure, there is not side effect in larger scale for this. I take that you have done due diligence or we will get his tested before release in case we are not 100 % sure.

68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f4665726a71504859324f4744504a5077456b2f67697068792e676966

@Tatsinnit we will get this tested before we release it. and I have temporary/preview VSIX just in case if someone wants to try this. :) Thank you.

azure-pipelines.yml Outdated Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
peterbom
peterbom previously approved these changes Dec 21, 2023
Copy link

@peterbom peterbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few questions because I don't fully understand the pipeline and some of the job/task names don't seem to explain things...but overall I like the changes, particularly if it avoids runtime code signing on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants