This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Validate header value in AddResponseFromClaims #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kestrel server doesn't allow non-ascii characters in header values. It throws InvalidOperationException if a header value contains non-ascii char.
|
Fixes issue #26 |
|
I'm ok with accepting this change. We'll need to update the docs to reflect this as a limitation. I think we can go ahead and merge this now and revisit documentation in the June sprint. I'll have changes to make in this area as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kestrel doesn't allow non-ascii characters in header values.
It throws InvalidOperationException if a header value contains non-ascii char.
This issue happens only with Kestrel because it has a different implementation of IHeaderDictionary.