-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
husamhilal review #1 of Networking Guide #259
Conversation
@fguerri @sblair01 @prasad3017 -bullet #4 at explaining Figure 1 - My question is: Leveraging DNAT and SNAT rules at NSX-T cannot we control if Public IP can be used only for Outbound but not for Inbound?
Looks great! mainly formatting changes!
In the diagram, it says "Read section: Connectivity with Azure VNet when ER Transit not used"... would probably make sense to actually point to that explicitly in the documentation page. Also, there is no specific paragraph talking about UDR (following the diagram) in that section. @fguerri @prasad3017 @sblair01
added note about Application Gateway and Azure firewalls. + minor formatting changes @fguerri
minor formatting changes
added a new line "<br>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @husamhilal for reviewing. Please see my observations in the comments and let me know what you think.
Thanks a lot @fguerri for the feedback. I addressed the points you mentioned. So, you can merge if you'd like to. I also added comments to my initial commits, not sure if you got those as feedback for further enhancements. |
I have not gone through the other comments yet. I will do. For now, merging the changes that you suggested in this PR. |
Sounds a great plan. Thanks @fguerri 👍 |
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
As part of this Pull Request I have
main
branch