Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ER/VPN GW subnet input requirements for vWAN deployments #789

Closed
daltondhcp opened this issue Sep 8, 2021 · 0 comments · Fixed by #799
Closed

Remove ER/VPN GW subnet input requirements for vWAN deployments #789

daltondhcp opened this issue Sep 8, 2021 · 0 comments · Fixed by #799
Assignees
Labels
bug Something isn't working engineering engineering work

Comments

@daltondhcp
Copy link
Contributor

Describe the bug
When deploying the RI with vWAN network topology along with VPN/ER gateway, gateway subnet CIDR validation fails regardless of input.
Since the vWAN hub assigns subnets automatically to various gateways from the managed hub address space, gateway subnet input should not be asked for at all in those scenarios.

Note that the subnet input requirement was introduced in #613, but the CIDR validation issue helped us to surface this 😃

Steps to reproduce

  1. Launch Azure Landing Zone accelerator, and complete sections until arrive to the Network topology and connectivity section.
  2. Select Virtual WAN (Microsoft Managed)
  3. Select to deploy VPN/ExpressRoute gateway or VPN gateway
  4. Notice how the subnet validation fails regardless of input

Screenshots
image
image

@daltondhcp daltondhcp added bug Something isn't working engineering engineering work labels Sep 8, 2021
@krnese krnese assigned krnese and unassigned marvinbuss Sep 8, 2021
@marvinbuss marvinbuss linked a pull request Sep 9, 2021 that will close this issue
6 tasks
@marvinbuss marvinbuss self-assigned this Sep 10, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working engineering engineering work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants